Skip to content

201 test failures#202

Open
pseewald wants to merge 10 commits intofortran-lang:masterfrom
pseewald:201-test-failures
Open

201 test failures#202
pseewald wants to merge 10 commits intofortran-lang:masterfrom
pseewald:201-test-failures

Conversation

@pseewald
Copy link
Copy Markdown
Collaborator

This is work in progress to fix current test failures introduced by #186.

  • I removed indent_misaligned condition because it doesn't make much sense to me (as commented already in Specify the amount of spaces before inline comments #186 (comment))
  • adapted checks for non-whitespace changes in tests to take new auto break feature into account
  • added a unit test which is expected to fail due to an issue with statement labels being removed

@zandivx Could you please fix the unit test failure? Then all other tests should pass as well. You can push to this pr, or create a new pr, as you prefer.

Could you also review this pr (in particular, if you agree with removing indent_misaligned condition)?

@pseewald pseewald requested a review from certik February 23, 2026 10:14
@zandivx
Copy link
Copy Markdown
Contributor

zandivx commented Feb 23, 2026

I cannot push to your branch, so I made a PR for this branch.

@pseewald
Copy link
Copy Markdown
Collaborator Author

Further issue:

  • ./run_tests.py -s regular yields different results if run twice (3 additional failures)

When write_formatted_line splits a long line (via _insert_split_chunks
or _detach_inline_comment), the statement label was consumed but never
restored for the replacement lines. This caused labels like "1003" to
be silently dropped from FORMAT statements that exceeded the line length
limit.

Three issues addressed in write_formatted_line:
- Restore the label after split/detach so it appears on the first chunk
- In the overflow fallback path, prepend the label when orig_line lacks it
- When detaching an inline comment from a labeled line, compensate the
  comment's indent for the label-replacement space inflation

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@pseewald pseewald removed the request for review from certik February 23, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants