W-22352906 W-22352907: fix(deps): bump nock and ts-morph major versions#284
Open
npiccolo wants to merge 2 commits into
Open
W-22352906 W-22352907: fix(deps): bump nock and ts-morph major versions#284npiccolo wants to merge 2 commits into
npiccolo wants to merge 2 commits into
Conversation
- nock v13 → v14 - ts-morph v24 → v28 - ts-patch v3 → v4 - typescript v5 → v6 - Add "types": ["mocha"] to test/tsconfig.json for TypeScript 6 compatibility - Set TS_NODE_PROJECT=test/tsconfig.json in test:only wireit env Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
npiccolo
force-pushed
the
npz/majorVersions
branch
from
5b31886 to
200187d
Compare
ts-patch v4 requires TypeScript >= 6, and TypeScript 6 is incompatible with @typescript-eslint v6 pinned by @salesforce/dev-scripts v11. Reverting both until dev-scripts ships support for TypeScript 6. W-22352909 and W-22352910 remain open pending dev-scripts upgrade. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
npiccolo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nock(v13→v14),ts-morph(v24→v28)ts-patch(W-22352909) andtypescript(W-22352910) are blocked:ts-patch v4requires TypeScript >= 6, and TypeScript 6 is incompatible with
@typescript-eslintv6 pinned by
@salesforce/dev-scripts v11. Both will be addressed once dev-scriptsships support for TypeScript 6.
Test plan
package.json—nockbumped to^14.0.15,ts-morphbumped to^28.0.0Optional manual testing
yarn install && yarn build— verify compilation and lint pass locallyyarn test:only— verify all unit tests pass locallyGUS: @W-22352906@ @W-22352907@
🤖 Generated with Claude Code