feat(opentype): add fsselection_wws check#684
Open
felipesanches wants to merge 2 commits into
Open
Conversation
Warn when OS/2 fsSelection bit 8 (WWS) is inconsistent with name table entries. If name IDs 21/22 are absent (font naming is already WWS-conformant), the WWS bit should be set. If name IDs 21/22 are present, the WWS bit should not be set. Fixes fonttools#577 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add rich Metadata::TableProblem to both warn Status results for machine-readable output. Add 4 Rust tests covering all combinations: - WWS bit set without name IDs 21/22 (pass) - WWS bit unset with name IDs 21/22 (pass) - WWS bit set with name IDs 21/22 (warn: wws-with-wws-names) - WWS bit unset without name IDs 21/22 (warn: no-wws-without-wws-names) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opentype/fsselection_wwscheck to the OpenType profileMetadata::TableProblemon all warn results for machine-readable outputFixes #577
Test plan
cargo buildpassescargo testpasses (4 new tests: 2 passing cases, 2 warning cases)cargo fmt --all -- --checkpassescargo clippy -p fontspector-profile-opentype -- -D warningspasses🤖 Generated with Claude Code