feat(opentype): add STAT/no_duplicate_axis_values check#674
Open
felipesanches wants to merge 2 commits into
Open
feat(opentype): add STAT/no_duplicate_axis_values check#674felipesanches wants to merge 2 commits into
felipesanches wants to merge 2 commits into
Conversation
Detects duplicate axis value entries in the STAT table (same axis index and value combination). Supports all 4 axis value formats. Includes Metadata::TableProblem on all statuses. Closes fonttools#199 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add test_fail_duplicate_axis_values that constructs a font with a STAT table containing two Format1 entries with the same axis index and value, verifying the check correctly emits a "duplicate-axis-value" failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opentype/STAT/no_duplicate_axis_valuesthat detects duplicate axis value entries in the STAT tableMetadata::TableProblemon all statusesCloses #199
Test plan
cargo buildpassescargo testpasses (3 tests)cargo fmt --all -- --checkpassescargo clippy -- -D warningspasses