Skip to content

Fix UnboundLocalError in Markdown report when all checks pass #5059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterDekkers wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −3
Open

Fix UnboundLocalError in Markdown report when all checks pass #5059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
455cb2c
Fix variable referenced before assignment
PeterDekkers Mar 1, 2026
87eae62
Update CHANGELOG
PeterDekkers Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ A more detailed list of changes is available in the corresponding milestones for

## Upcoming release v1.1.1 (2025-Oct-?)

### Bugfixes
- Fix an issue where Markdown reports throw an error when all checks pass (PR #5059)

### Changes to existing checks
#### On the OpenType profile
- **[opentype/monospace]**: Ensure check works with monospace OTF fonts (PR #5051)
Expand Down
5 changes: 2 additions & 3 deletions Lib/fontbakery/reporters/ghmarkdown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def template(self, data):
fatal_checks = {}
experimental_checks = {}
other_checks = {}
deprecation_warning = None

num_checks = 0
for section in data["sections"]:
Expand Down Expand Up @@ -77,7 +78,7 @@ def template(self, data):
other_checks[key] = []
other_checks[key].append(check)

if self.legacy_checkid_references:
if deprecation_warning is None and self.legacy_checkid_references:
references = "\n - ".join(self.legacy_checkid_references)
deprecation_warning = (
"By late-December 2024, FontBakery version 0.13.0"
Expand All @@ -97,8 +98,6 @@ def template(self, data):
f" - {references}\n"
"\n"
)
else:
deprecation_warning = None

# Sort them by log-level results:
ordering = ["ERROR", "FATAL", "FAIL", "WARN", "INFO", "PASS", "SKIP"]
Expand Down
Loading