fix: escaping PDF Object Names (space in spot color name fix)#1716
Open
tr1stan wants to merge 2 commits intofoliojs:masterfrom
Open
fix: escaping PDF Object Names (space in spot color name fix)#1716tr1stan wants to merge 2 commits intofoliojs:masterfrom
tr1stan wants to merge 2 commits intofoliojs:masterfrom
Conversation
Member
|
Thanks. I will take a look. We should escape the minimal places so the chance to regression is smaller |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, making sure we're not sending un-escaped chars to the PDF object name.
Fixes: #1644
Checklist:
Having traced where the
.convert(method is being used, this is the easiest way to get the fix in, happy to look at alternatives if we feel it's too broad.