Skip to content

UIREQ-1361: Bump major version (Trillium) of optional dependency#1367

Merged
mariia-aloshyna merged 1 commit into
masterfrom
UIREQ-1361
May 6, 2026
Merged

UIREQ-1361: Bump major version (Trillium) of optional dependency#1367
mariia-aloshyna merged 1 commit into
masterfrom
UIREQ-1361

Conversation

@mariia-aloshyna
Copy link
Copy Markdown
Contributor

Purpose

Use Trillium version of optionalDependency

Approach

Bump major version of optionalDependencies (@folio/plugin-find-instance)

Refs

https://folio-org.atlassian.net/browse/UIREQ-1361

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Jest Unit Test Results

    1 files  ±0     66 suites  ±0   1m 38s ⏱️ +4s
  889 tests ±0    889 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 251 runs  ±0  1 251 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 91fb4ef. ± Comparison against base commit 5bccac2.

♻️ This comment has been updated with latest results.

@mariia-aloshyna mariia-aloshyna requested a review from a team May 5, 2026 09:56
Comment thread package.json Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@mariia-aloshyna mariia-aloshyna merged commit 0d834a6 into master May 6, 2026
15 checks passed
@mariia-aloshyna mariia-aloshyna deleted the UIREQ-1361 branch May 6, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants