Skip to content

CIRC-2384 Add permission for Anonymizing Single Request#1365

Open
brycekbargar wants to merge 3 commits into
folio-org:masterfrom
Five-Colleges-Incorporated:circ-2384
Open

CIRC-2384 Add permission for Anonymizing Single Request#1365
brycekbargar wants to merge 3 commits into
folio-org:masterfrom
Five-Colleges-Incorporated:circ-2384

Conversation

@brycekbargar
Copy link
Copy Markdown
Contributor

Purpose

Anonymizing users through the UI has to be gated by a permission. The permission for the frontend depends on the API permission added to the backend.

Approach

This was the only documentation I could find on adding permissions. I tried to follow the format and pattern of the other permissions in the file.

Refs

https://folio-org.atlassian.net/browse/CIRC-2384
Backend PR

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link
Copy Markdown
Contributor

@Dmitriy-Litvinenko Dmitriy-Litvinenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Just a heads-up: I will be on vacation until the end of next week and will be unavailable. You can discuss the feedback below with @folio-org/fe-tl-reviewers on GitHub or wait until I return.

Before proceeding, could you please confirm if we need to add or change "okapiInterfaces"? If so, additional changes will be required; otherwise, please address the feedback below:

CHANGELOG.md & package.json:

  1. Version Update: Bump version from 13.0.0 to 13.1.0 in both files, as 13.0.0 has already been released.
  2. Ticket References:
  • Correct UIREQ-12363 (this ticket does not exist).
  • Remove the backend reference CIRC-2364; the UI changelog should only include UI-related tickets.
    en.json:
  1. Missing Translation: Add the following key:
    "permission.anonymizeSingleRequest.execute": "Requests: Anonymize a single request"

Let me know if you have any questions. Looking forward to the update.

@Dmitriy-Litvinenko Dmitriy-Litvinenko requested a review from a team April 30, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants