UICIRC-942: Reminder print files#1110
Conversation
MikeTaylor
left a comment
MikeTaylor
left a comment
There was a problem hiding this comment.
This looks reasonable. I just worry about dependency proliferation.
| route: 'patron-notice-print-jobs', | ||
| label: this.props.intl.formatMessage({ id: 'ui-circulation.settings.index.patronNoticePrintJobs' }), | ||
| component: PatronNoticePrintJobs, | ||
| perm: 'mod-batch-print.entries.collection.get', |
There was a problem hiding this comment.
Once we finally merge folio-org/stripes-smart-components#1401 you'll be able to also add here:
iface: 'batch-print',
to support optionality.
| @@ -0,0 +1 @@ | |||
| jest.mock('currency-codes/data', () => ({ filter: () => [] })); | |||
There was a problem hiding this comment.
Is this related to the main purpose of the PR?
(Not a killer if it isn't, I just want to understand.)
There was a problem hiding this comment.
@MikeTaylor yes. I needed to use MCL in the tests (not a mocked MCL) but then started getting errors related to currency codes. By including a mock I was able to bypass it. A similar pattern is used in most other UI modules.
|
* UICIRC-942: Add new page for access of reminder print files * UICIRC-942: Connect Print UI to the backend * fix print jobs * Adjust print jobs * Cleanup * Add tests * Use new API for mutli removal * Fix tests * Cleanup * Cleanup * Add more tests * Update permission * batch-print to optionalOkapiInterfaces * Use callout for errors * Fix tests
|
Thanks, @mkuklis, this all looks better now. I'm always taken by surprise at how easy it is to use callouts! I do think though that you need to protect your top-level settings page so that the new settings are only included when the appropriate interface is provided. |
2 participants
https://issues.folio.org/browse/UICIRC-942
Add
Patron notice print jobsto circulation settings.