STUTL-37: Add escapeCqlValueAllowAsterisk to only escape " \ ^ ? and not escape *.#73
Closed
Dmytro-Melnyshyn wants to merge 1 commit into
Closed
STUTL-37: Add escapeCqlValueAllowAsterisk to only escape " \ ^ ? and not escape *.#73Dmytro-Melnyshyn wants to merge 1 commit into
escapeCqlValueAllowAsterisk to only escape " \ ^ ? and not escape *.#73Dmytro-Melnyshyn wants to merge 1 commit into
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
zburke
added a commit
that referenced
this pull request
Jul 24, 2023
This reverts commit 2a77364. This appears to be a likely cause of > 150 e2e test failures when tests rely on an asterisk as part of a wildcard search. We may eventually decide to keep this work, alongside a function that permits the asterisk, as outlined in STUTL-37 / PR #73, but we'll want to rearrange the order of operations (implement that function, then convert existing search code to use that function, and only then implement the breaking change outlined in STUTL-33).
Member
|
@Dmytro-Melnyshyn , we've reverted #69. Let's see how tests go with that change in place, and then we can decide if/how to proceed with this function. |
Member
|
STUTL-37 has been closed as "Won't Do". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The asterisk has recently been escaped in
escapeCqlValue#69.The suggested solution is to create a separate #73 function to support the asterisk.
Related PRs
stripes-smart-components/pull/1382
Issue
STUTL-37