[STTYPES-6] [UILISTS-92] Add typings for SearchAndSort and friends#51
Merged
Conversation
ncovercash
requested review from
JohnC-80,
bvsharp,
kjain110,
mweaver-ebsco and
zburke
ncovercash
changed the title
|
mweaver-ebsco
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira STTYPES-6
Jira UILISTS-92
This PR adds typings for
SearchAndSort, associated components (filters, buttons, etc), andColumnManager.Per discussion with @zburke and @JohnC-80 the connect-related typings may not be perfect, but we're discouraging its use in new code, so we're OK with this level of detail.
This must be merged after folio-org/ui-lists#92
✨ Bonus ✨
PRs made to fix documentation issues in other ilbraries