-
Notifications
You must be signed in to change notification settings - Fork 20
FAT-26217: Implements C499692 #7113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zepheiryan
wants to merge
8
commits into
master
Choose a base branch
from
FAT-26217
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
be0419e
Removed ExternalResourcePreview in favor of PreviewResource previousl…
zepheiryan d5366c3
Add nearly complete test for language code with supporting fixture an…
zepheiryan 0baa005
Include inventory capability sets
zepheiryan 1f93709
Use TopMenuNavigation, and swap out keyboard interactor for .type()
zepheiryan a938d11
Merge branch 'master' into FAT-26217
zepheiryan 5d1fb47
Pull out constants
zepheiryan ad1231b
Merge remote-tracking branch 'origin/FAT-26217' into FAT-26217
zepheiryan b776eb6
Fix constant substitution
zepheiryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
221 changes: 221 additions & 0 deletions
221
cypress/e2e/linked-data/LD Edit/language-code-marc.cy.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,221 @@ | ||
| import { | ||
| APPLICATION_NAMES, | ||
| DEFAULT_JOB_PROFILE_NAMES, | ||
| EDIT_RESOURCE_HEADINGS, | ||
| } from '../../../support/constants'; | ||
| import CapabilitySets from '../../../support/dictionary/capabilitySets'; | ||
| import getRandomPostfix from '../../../support/utils/stringTools'; | ||
| import FileManager from '../../../support/utils/fileManager'; | ||
|
|
||
| import DataImport from '../../../support/fragments/data_import/dataImport'; | ||
| import InventoryInstance from '../../../support/fragments/inventory/inventoryInstance'; | ||
| import InventoryInstances from '../../../support/fragments/inventory/inventoryInstances'; | ||
| import InstanceRecordEdit from '../../../support/fragments/inventory/instanceRecordEdit'; | ||
| import InventorySearchAndFilter from '../../../support/fragments/inventory/inventorySearchAndFilter'; | ||
| import TopMenu from '../../../support/fragments/topMenu'; | ||
| import TopMenuNavigation from '../../../support/fragments/topMenuNavigation'; | ||
| import Users from '../../../support/fragments/users/users'; | ||
|
|
||
| import EditResource from '../../../support/fragments/linked-data/editResource'; | ||
| import InstanceProfileModal from '../../../support/fragments/linked-data/instanceProfileModal'; | ||
| import Marigold from '../../../support/fragments/linked-data/marigold'; | ||
| import PreviewResource from '../../../support/fragments/linked-data/previewResource'; | ||
| import SearchAndFilter from '../../../support/fragments/linked-data/searchAndFilter'; | ||
| import ViewMarc from '../../../support/fragments/linked-data/viewMarc'; | ||
| import Work from '../../../support/fragments/linked-data/work'; | ||
| import WorkProfileModal from '../../../support/fragments/linked-data/workProfileModal'; | ||
|
|
||
| import { | ||
| MARIGOLD_CAPABILITIES, | ||
| MARIGOLD_CAPABILITY_SETS, | ||
| } from '../../../support/dictionary/marigoldCapabilities'; | ||
|
|
||
| let user; | ||
|
|
||
| describe('Citation: check language MARC codes', () => { | ||
| const testData = { | ||
| workId: null, | ||
| instanceId: null, | ||
| marcFilePath: 'marcFileForC499692.mrc', | ||
| modifiedMarcFile: `C499692 editedMarcFile${getRandomPostfix()}.mrc`, | ||
| marcFileName: `C499692 marcFile${getRandomPostfix()}.mrc`, | ||
| uniqueInventoryTitle: `Language code inventory ${getRandomPostfix()}`, | ||
| uniqueMarigoldWorkTitle: `Lanuage code Marigold ${getRandomPostfix()}`, | ||
| uniqueMarigoldInstanceTitle: `Lanuage code Marigold ${getRandomPostfix()}`, | ||
| }; | ||
|
|
||
| const resourceData = { | ||
| inventoryTitle: testData.uniqueInventoryTitle, | ||
| marigoldWorkTitle: testData.uniqueMarigoldWorkTitle, | ||
| marigoldInstanceTitle: testData.uniqueMarigoldInstanceTitle, | ||
| language: 'English', | ||
| languageCode: 'eng', | ||
| languageRel: 'Primary source language', | ||
| languageLink: 'http://id.loc.gov/vocabulary/languages/eng', | ||
| languageSelect: 'English (eng)', | ||
| marcLanguageCode: '$a eng', | ||
| marc008LangPosition: 36, | ||
| languagesSubset: [ | ||
| 'Akkadian (akk)', | ||
| 'Bemba (bem)', | ||
| 'Croatian (hrv)', | ||
| 'Kanuri (kau)', | ||
| 'Nepali (nep)', | ||
| 'Uighur (uig)', | ||
| 'Zaza (zza)', | ||
| ], | ||
| languageRelationships: [ | ||
| 'Primary source language', | ||
| 'Summary or abstract', | ||
| 'Sung or spoken text', | ||
| 'Librettos', | ||
| 'Table of contents', | ||
| 'Accompanying material other than librettos and transcripts', | ||
| 'Original language', | ||
| 'Intertitles', | ||
| 'Subtitles', | ||
| 'Intermediate translation', | ||
| 'Original accompanying materials other than librettos', | ||
| 'Original libretto', | ||
| 'Captions', | ||
| 'Accessible audio', | ||
| 'Accessible visual language (non-textual)', | ||
| 'Accompanying transcripts for audiovisual material', | ||
| ], | ||
| }; | ||
|
|
||
| const fieldData = { | ||
| languageSection: 'Language code', | ||
| languageField: 'Language', | ||
| languageRelField: 'Language relationship', | ||
| workTitle: 'Preferred Title for Work', | ||
| instanceTitle: 'Main Title', | ||
| ldSource: 'LINKED_DATA', | ||
| }; | ||
|
|
||
| before('Create test data', () => { | ||
| DataImport.editMarcFile( | ||
| testData.marcFilePath, | ||
| testData.modifiedMarcFile, | ||
| ['Placeholder Title Language Code'], | ||
| [testData.uniqueInventoryTitle], | ||
| ); | ||
| cy.getAdminToken(); | ||
|
|
||
| cy.createTempUser([]).then((userProperties) => { | ||
| user = userProperties; | ||
| cy.assignCapabilitiesToExistingUser( | ||
| user.userId, | ||
| MARIGOLD_CAPABILITIES, | ||
| [ | ||
| ...MARIGOLD_CAPABILITY_SETS, | ||
| CapabilitySets.uiInventoryInstanceView, | ||
| CapabilitySets.uiInventoryInstanceEdit, | ||
| ], | ||
| ); | ||
| }); | ||
|
|
||
| DataImport.uploadFileViaApi( | ||
| testData.modifiedMarcFile, | ||
| testData.marcFileName, | ||
| DEFAULT_JOB_PROFILE_NAMES.CREATE_INSTANCE_AND_SRS, | ||
| ); | ||
| }); | ||
|
|
||
| after('Delete test data', () => { | ||
| FileManager.deleteFile(`cypress/fixtures/${testData.modifiedMarcFile}`); | ||
| cy.getAdminToken(); | ||
| InventoryInstances.deleteFullInstancesByTitleViaApi(resourceData.inventoryTitle); | ||
| InventoryInstances.deleteFullInstancesByTitleViaApi(resourceData.marigoldInstanceTitle); | ||
| Work.getInstancesByTitle(resourceData.inventoryTitle).then((instances) => { | ||
| const filteredInstances = instances.filter( | ||
| (element) => element.titles[0].value === resourceData.inventoryTitle, | ||
| ); | ||
| Work.deleteById(filteredInstances[0].id); | ||
| }); | ||
| Work.getIdByTitle(resourceData.inventoryTitle).then((id) => Work.deleteById(id)); | ||
| if (testData.instanceId) Work.deleteInstanceViaApi(testData.instanceId); | ||
| if (testData.workId) Work.deleteById(testData.workId); | ||
| Users.deleteViaApi(user.userId); | ||
| }); | ||
|
|
||
| beforeEach(() => { | ||
| cy.login(user.username, user.password, { | ||
| path: TopMenu.inventoryPath, | ||
| waiter: InventoryInstances.waitContentLoading, | ||
| authRefresh: true, | ||
| }); | ||
| }); | ||
|
|
||
| it( | ||
| 'C499692 Marigold - Language Code Work / Inventory / View MARC', | ||
| { tags: ['criticalPath', 'citation', 'C499692', 'marigold'] }, | ||
| () => { | ||
| // Edit instance from Inventory | ||
| InventoryInstances.searchByTitle(resourceData.inventoryTitle); | ||
| InventoryInstance.editInstanceInMG(); | ||
| PreviewResource.waitLoading(); | ||
| PreviewResource.clickContinue(); | ||
| EditResource.waitLoading(EDIT_RESOURCE_HEADINGS.EDIT_INSTANCE); | ||
| EditResource.clickEditWork(); | ||
| EditResource.waitLoading(EDIT_RESOURCE_HEADINGS.EDIT_WORK); | ||
|
|
||
| // Check work language fields | ||
| EditResource.checkLabelOnSimpleField(resourceData.languageSelect, fieldData.languageField); | ||
| EditResource.checkDropdownTextValue(resourceData.languageRel, fieldData.languageRelField); | ||
| EditResource.checkSimpleFieldDropdownContainsOptions(fieldData.languageField, resourceData.languagesSubset); | ||
| EditResource.checkDropdownContainsOptions(fieldData.languageRelField, resourceData.languageRelationships); | ||
|
|
||
| // Review MARC | ||
| EditResource.editInstanceFormViaActions(); | ||
| EditResource.waitLoading(EDIT_RESOURCE_HEADINGS.EDIT_INSTANCE); | ||
| EditResource.viewMarc(); | ||
| ViewMarc.waitLoading(); | ||
| ViewMarc.checkMarcFieldContainsDataAtPosition('008', resourceData.marc008LangPosition, resourceData.languageCode); | ||
| ViewMarc.checkMarcFieldIndicators('041', ' '); | ||
| ViewMarc.checkMarcFieldContainsData('041', resourceData.marcLanguageCode); | ||
|
|
||
| // Create new work and instance | ||
| ViewMarc.closeMarcView(); | ||
| EditResource.waitLoading(EDIT_RESOURCE_HEADINGS.EDIT_INSTANCE); | ||
| EditResource.clickCloseResourceButton(); | ||
| Marigold.waitLoading(); | ||
| Marigold.openNewResourceForm(); | ||
| WorkProfileModal.waitLoading(); | ||
| WorkProfileModal.selectDefaultOption(); | ||
| EditResource.waitLoading(EDIT_RESOURCE_HEADINGS.NEW_WORK); | ||
| EditResource.setValueForTheField(testData.uniqueMarigoldWorkTitle, fieldData.workTitle); | ||
| EditResource.setValueForSectionSimpleField(resourceData.languageSelect, fieldData.languageField); | ||
| // Primary source language is already the default language relationship selection | ||
| EditResource.saveAndKeepEditingWithId(({ resourceId }) => { | ||
| testData.workId = resourceId; | ||
| }); | ||
| EditResource.waitLoading(EDIT_RESOURCE_HEADINGS.EDIT_WORK); | ||
| EditResource.openNewInstanceFormViaNewInstanceButton(); | ||
| InstanceProfileModal.waitLoading(); | ||
| InstanceProfileModal.selectDefaultOption(); | ||
| EditResource.waitLoading(EDIT_RESOURCE_HEADINGS.NEW_INSTANCE); | ||
| EditResource.setValueForTheField(testData.uniqueMarigoldInstanceTitle, fieldData.instanceTitle); | ||
| EditResource.saveAndKeepEditingWithId(({ resourceId }) => { | ||
| testData.instanceId = resourceId; | ||
| }); | ||
| EditResource.clickCloseResourceButton(); | ||
|
|
||
| Marigold.waitLoading(); | ||
| SearchAndFilter.searchResourceByTitle(resourceData.marigoldWorkTitle); | ||
| SearchAndFilter.verifySearchResultField(resourceData.languageCode); | ||
| SearchAndFilter.openSearchResultPreviewByTitle(resourceData.marigoldWorkTitle); | ||
| SearchAndFilter.waitPreviewLoading(); | ||
| EditResource.checkPreviewSectionContainsLink(fieldData.languageSection, fieldData.languageField, resourceData.language, resourceData.languageLink); | ||
|
|
||
| // Review in inventory | ||
| TopMenuNavigation.navigateToApp(APPLICATION_NAMES.INVENTORY); | ||
| InventoryInstances.waitContentLoading(); | ||
| InventorySearchAndFilter.bySource(fieldData.ldSource); | ||
| InventoryInstances.searchByTitle(resourceData.marigoldInstanceTitle); | ||
| InventoryInstance.editInstance(); | ||
| InstanceRecordEdit.waitLoading(); | ||
| InstanceRecordEdit.verifyLanguage(resourceData.language); | ||
| }, | ||
| ); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 00182naa a2200073uu 4500001001400000005001700014008004100031245003600072 in00000000705 20260508181845.2 260508| ||| | eng aPlaceholder Title Language Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add please 'C499692 Marigold - Language Code Work / Inventory / View MARC (citation)'