OKAPI-1243: equals should support subclasses of ModuleId, SemVer, … #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

julianladisch merged 3 commits into master from OKAPI-1243

Apr 2, 2026

Merged

OKAPI-1243: equals should support subclasses of ModuleId, SemVer, … #1442

Merge branch 'master' into OKAPI-1243

SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 1, 2026 in 44s

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 65 in okapi-common/src/test/java/org/folio/okapi/common/SemVerTest.java

sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

See more on https://sonarcloud.io/project/issues?id=org.folio.okapi%3Aokapi&issues=AZ1JFLISraWf0r1Xdv4U&open=AZ1JFLISraWf0r1Xdv4U&pullRequest=1442

Check warning on line 47 in okapi-common/src/test/java/org/folio/okapi/common/ModuleIdTest.java

sonarqubecloud / SonarCloud Code Analysis

Use assertNotEquals instead.

See more on https://sonarcloud.io/project/issues?id=org.folio.okapi%3Aokapi&issues=AZ1JFLI4raWf0r1Xdv4W&open=AZ1JFLI4raWf0r1Xdv4W&pullRequest=1442

Check warning on line 64 in okapi-common/src/test/java/org/folio/okapi/common/ModuleIdTest.java

sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

See more on https://sonarcloud.io/project/issues?id=org.folio.okapi%3Aokapi&issues=AZ1JFLI4raWf0r1Xdv4V&open=AZ1JFLI4raWf0r1Xdv4V&pullRequest=1442

View more details on SonarQubeCloud