Skip to content

CIRC-2531 storage layer for request anonymization#1651

Merged
longvo-cv merged 11 commits into
masterfrom
CIRC-2531-Storage-Layer-For-Request-Anonymization
May 7, 2026
Merged

CIRC-2531 storage layer for request anonymization#1651
longvo-cv merged 11 commits into
masterfrom
CIRC-2531-Storage-Layer-For-Request-Anonymization

Conversation

@longvo-cv
Copy link
Copy Markdown
Contributor

CIRC-2531: Storage Layer for Request Anonymization

What does this PR do?

Implements the storage layer for automated request anonymization, mirroring the existing loan anonymization pattern.

Changes

  • New file: AnonymizeStorageRequestsRepository - batch anonymization to storage module
  • Modified: RequestRepository - added findRequestsToAnonymize() and findClosedRequests()
  • Modified: RequestStatus - added closedStates() method
  • Modified: Clients - added anonymizeStorageRequestsClient()

Pattern

Mirrors LoanRepository and AnonymizeStorageLoansRepository exactly as specified in the ticket.

Ticket

https://folio-org.atlassian.net/browse/CIRC-2531

@longvo-cv longvo-cv requested a review from yuntianhu February 5, 2026 16:40
Comment thread src/main/java/org/folio/circulation/domain/RequestStatus.java Outdated
Comment thread src/main/java/org/folio/circulation/support/Clients.java Outdated
throws MalformedURLException {

return getCollectionResourceClient(client, context,
"/request-storage/requests/anonymize");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see this endpoint built at anywhere. may I know where is this endpoint declared?
from what I understand, we should use circulation setting/circulation setting storage endpoints
please read the design
https://folio-org.atlassian.net/wiki/spaces/DD/pages/1056210996/Request+anonymization

@yuntianhu
Copy link
Copy Markdown
Contributor

yuntianhu commented Mar 27, 2026

HI @longvo-cv, it seems like you are out of sync. could you rebase first, thank you

@yuntianhu yuntianhu self-requested a review March 27, 2026 16:18
@alexanderkurash alexanderkurash changed the title Circ 2531 storage layer for request anonymization CIRC-2531 storage layer for request anonymization Mar 30, 2026
@longvo-cv longvo-cv force-pushed the CIRC-2531-Storage-Layer-For-Request-Anonymization branch from de8c54b to 554fa2a Compare April 9, 2026 15:33
@longvo-cv longvo-cv self-assigned this Apr 14, 2026
Copy link
Copy Markdown
Contributor

@alexanderkurash alexanderkurash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Sonar issues

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 1, 2026

@longvo-cv
Copy link
Copy Markdown
Contributor Author

@alexanderkurash Finished!

@longvo-cv longvo-cv requested a review from alexanderkurash May 5, 2026 16:08
@longvo-cv
Copy link
Copy Markdown
Contributor Author

@alexanderkurash Can I ask for the final check off before merging

@longvo-cv longvo-cv merged commit 6927ee0 into master May 7, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants