Skip to content

Initial pass at onnx wiring into SpotObserver - #15

Open
jPorterDosch wants to merge 9 commits into
mainfrom
feat/switch-onnx-models
Open

Initial pass at onnx wiring into SpotObserver#15
jPorterDosch wants to merge 9 commits into
mainfrom
feat/switch-onnx-models

Conversation

@jPorterDosch

Copy link
Copy Markdown
Collaborator
  • given MeTRICS streaming onnx file, wire it in for live demo
  • modular function calls for each ONNX model type so live pipeline switch is possible

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

🧹 Ruff — ❌ 15 new issues

Check Result
Lint ❌ 15 new (10 auto-fixable), 91 inherited
Top new I001 +7 🔴
Format ❌ 5 file(s) need formatting (5 checked)

Files needing format:

onnx/set_window.py
tests/streaming-harness/gen_integ_test.py
tests/streaming-harness/gen_kernel_test.py
tests/streaming-harness/gen_ort_check.py
tests/streaming-harness/make_stub_model.py

Important

  1. Auto-fix issues:
    • VSCode: "Ruff: Format document" + "Ruff: Format imports" + "Ruff: Fix all auto-fixable problems"
    • CLI: ruff check --fix . && ruff format .
    • Bot: Comment /ruff fix on this PR
  2. Manually fix 5 new issue(s) that can't be auto-fixed (see Files changed)
  3. Push

Tip

VSCode: Set up auto-format and code actions on save

Settings UI: Search "format on save" and "code actions on save"

settings.json:

"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
  "source.fixAll.ruff": "explicit",
  "source.organizeImports.ruff": "explicit"
}

Full setup guide →

🔴 New Issues (15)

📦 I — isort

Rule Description Main PR Δ Auto-fixable
I001 Import block is un-sorted or un-formatted 2 9 +7 🔴 7 Safe (100%) ✅
Subtotal 2 9 +7 🔴 7 Safe (100%) ✅

🎨 E — pycodestyle

Rule Description Main PR Δ Auto-fixable
E402 Module level import not at top of file 0 3 +3 🔴 0 ❌
E401 Multiple imports on one line 0 3 +3 🔴 3 Safe (100%) ✅
Subtotal 0 6 +6 🔴 3 Safe (50%) ✅

📝 ANN — flake8-annotations

Rule Description Main PR Δ Auto-fixable
ANN202 Missing return type annotation for private function 5 6 +1 🔴 0 ❌
ANN001 Missing type annotation for function argument 16 17 +1 🔴 0 ❌
Subtotal 44 46 +2 🔴 0 ❌

Summary

Category Tool Main PR Δ Auto-fixable
📦 I isort 2 9 +7 🔴 7 Safe (100%) ✅
🎨 E pycodestyle 0 6 +6 🔴 3 Safe (50%) ✅
📝 ANN flake8-annotations 44 46 +2 🔴 0 ❌
Total 91 106 +15 🔴 10 Safe (66%) ✅

Bot commands for this PR

Type /ruff or @ruff followed by a command in a PR comment:

Command Description
check Run lint check only (no changes)
check --fix Auto-fix lint issues, commit to PR
format Auto-format code, commit to PR
format --check Check formatting only (no changes)
fix Recommended: check --fix + format

Reactions: 👀 = processing, 🚀 = all passing, 😕 = issues remain (details in reply)

View full logs →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant