Removing boost dependency and fixing tests#62
Draft
pedr-nz wants to merge 16 commits into
Draft
Conversation
added 16 commits
June 8, 2026 04:11
Deprecate support for `get_mpi_datatype()` (i.e. without argument) and also `get_cell_mpi_datatype_basic`. Update related test files.
By adding UNUSED_GMD_ARGS to comply with the supported function signature; and re-added the copy constructor removed from commit `bb8a995`.
Make get_cell_datatype conform with fnSig
- Conform to fnSig - Make sure to call ~Dccrg before MPI_Finalize - Wrap primitive type into wrapper - Disable array test as it hasn't bern finished yet - Suppress unused variable warning for this test
- Conform with fnSig - Wrap primitive types - Fix unneccessary parens - Add test name after PASS
- Conform with fnSig - Wrap primitive types
Basically my silly typo
GMD => get_mpi_datatype GCMD => get_cell_mpi_datatype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress:
maybe?