Skip to content

Add hooks to run before and after the popup appear#13

Open
lthms wants to merge 1 commit into
flycheck:masterfrom
lthms:feature/two-new-hooks
Open

Add hooks to run before and after the popup appear#13
lthms wants to merge 1 commit into
flycheck:masterfrom
lthms:feature/two-new-hooks

Conversation

@lthms

@lthms lthms commented Jul 29, 2022

Copy link
Copy Markdown

This is a simple proposal to have a way to run custom code when the popup is created and when it is deleted.

Here is how I use it:

(use-package eldoc-box
  :hook
  (eldoc-mode . eldoc-box-hover-at-point-mode)
  (flycheck-popup-tip-show . (lambda ()
                               (when eldoc-box-hover-at-point-mode
                                 (eldoc-box-hover-at-point-mode -1))))
  (flycheck-popup-tip-delete . (lambda ()
                                 (unless eldoc-box-hover-at-point-mode
                                   (eldoc-box-hover-at-point-mode)))))

Thanks to that, there is no conflict anymore between eldoc-box and flycheck-popup-tip.

Feel free to merge or close this PR, as you see fit.

Thanks for flycheck-popup-tip.

@CLAassistant

CLAassistant commented Jul 29, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@lthms
lthms force-pushed the feature/two-new-hooks branch from 3acb11b to 558e6e4 Compare August 6, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants