flux-job: fix spurious warning on guest eventlog follow - #7771
Merged
Conversation
Member
Author
|
Thanks! Setting MWP. |
Problem: an internal static array adds a NULL sentinel to implement an iterator. Use the CCAN ARRAY_SIZE() macro to avoid the need for a sentinel.
Problem: Some flux-job code formatting violates RFC 7. Break long parameter lists to one per line.
Problem: code that calls the job-list.lookup RPC puts the topic string in a variable for no particular reason. Just use the topic string in the RPC call directly, for clarity.
Problem: When the exec eventlog is processed by flux job eventlog --follow, a spurious "event 'clean' never received" warning message is printed. Look up the appropriate terminating event depending on which eventlog is selected. Fixes flux-framework#7766
Problem: there is no test coverage to show that flux job eventlog -F terminates without spurious error messages. Add a couple tests.
Problem: the flux job eventlog subcommand has no documentation. Add it to the man page.
Member
Author
|
Rebased on current master. |
Contributor
Merge Queue Status
This pull request spent 17 seconds in the queue, including 4 seconds running CI. Required conditions to merge
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7771 +/- ##
==========================================
+ Coverage 83.83% 83.86% +0.02%
==========================================
Files 599 599
Lines 102318 102321 +3
==========================================
+ Hits 85776 85808 +32
+ Misses 16542 16513 -29
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
does some gratuitous cleanup in that code area, and adds missing documentation.