Skip to content

test(kubeclient): add IsFinishedPod test cases #5770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r0hansaxena wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −0
Open

test(kubeclient): add IsFinishedPod test cases #5770

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
900593f
add finished pod cases
r0hansaxena Apr 7, 2026
6d0b9af
cover missing pod phases
r0hansaxena Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pkg/utils/kubeclient/pod_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,26 @@
})
})

Describe("IsFinishedPod", func() {
It("should return false for nil pod", func() {
Expect(IsFinishedPod(nil)).To(BeFalse())
})

DescribeTable("should correctly identify finished pods",
func(phase corev1.PodPhase, want bool) {
pod := &corev1.Pod{
ObjectMeta: metav1.ObjectMeta{Name: "testPod", Namespace: "default"},
Spec: corev1.PodSpec{},
Status: corev1.PodStatus{Phase: phase},
}
Expect(IsFinishedPod(pod)).To(Equal(want))
},
Entry("running pod", corev1.PodRunning, false),

Check failure on line 233 in pkg/utils/kubeclient/pod_test.go

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "running pod" 3 times. 


See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1mBe2iRPBJy-7nxH64&open=AZ1mBe2iRPBJy-7nxH64&pullRequest=5770
Entry("succeeded pod", corev1.PodSucceeded, true),
Entry("failed pod", corev1.PodFailed, true),

Check failure on line 235 in pkg/utils/kubeclient/pod_test.go

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "failed pod" 4 times. 


See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1mBe2iRPBJy-7nxH65&open=AZ1mBe2iRPBJy-7nxH65&pullRequest=5770
)
})

Describe("IsSucceededPod", func() {
DescribeTable("should correctly identify succeeded pods",
func(phase corev1.PodPhase, want bool) {
Expand Down
Loading