Skip to content

test(base): add owner dataset uid test cases #5769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r0hansaxena wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test(base): add owner dataset uid test cases #5769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4e259d
add owner uid tests
r0hansaxena Apr 6, 2026
3043824
add owner edge cases
r0hansaxena Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 118 additions & 0 deletions pkg/ddc/base/dataset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

datav1alpha1 "github.com/fluid-cloudnative/fluid/api/v1alpha1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
)

func TestGetPhysicalDatasetFromMounts(t *testing.T) {
Expand Down Expand Up @@ -266,3 +267,120 @@
})
}
}

func TestGetOwnerDatasetUIDFromRuntimeMeta(t *testing.T) {
uid := types.UID("dataset-uid-1")
tests := []struct {
name string
meta metav1.ObjectMeta
wantUID types.UID
expectErr bool
}{
{
name: "no owner references",
meta: metav1.ObjectMeta{
Name: "sample-runtime",

Check failure on line 282 in pkg/ddc/base/dataset_test.go

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "sample-runtime" 10 times. 


See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1kNxAwlZMhgCvZu0_P&open=AZ1kNxAwlZMhgCvZu0_P&pullRequest=5769
},
wantUID: "",
expectErr: false,
},
{
name: "no dataset owner",
meta: metav1.ObjectMeta{
Name: "sample-runtime",
OwnerReferences: []metav1.OwnerReference{
{
Kind: "Pod",
Name: "some-pod",
UID: types.UID("pod-uid"),
},
},
},
wantUID: "",
expectErr: false,
},
{
name: "single dataset owner with same name",
meta: metav1.ObjectMeta{
Name: "sample-runtime",
OwnerReferences: []metav1.OwnerReference{
{
Kind: datav1alpha1.Datasetkind,
Name: "sample-runtime",
UID: uid,
},
},
},
wantUID: uid,
expectErr: false,
},
{
name: "dataset owner name mismatch",
meta: metav1.ObjectMeta{
Name: "sample-runtime",
OwnerReferences: []metav1.OwnerReference{
{
Kind: datav1alpha1.Datasetkind,
Name: "another-name",
UID: uid,
},
},
},
wantUID: "",
expectErr: true,
},
{
name: "multiple dataset owners",
meta: metav1.ObjectMeta{
Name: "sample-runtime",
OwnerReferences: []metav1.OwnerReference{
{
Kind: datav1alpha1.Datasetkind,
Name: "sample-runtime",
UID: uid,
},
{
Kind: datav1alpha1.Datasetkind,
Name: "sample-runtime",
UID: types.UID("dataset-uid-2"),
},
},
},
wantUID: "",
expectErr: true,
},
{
name: "multiple owners with only one dataset owner",
meta: metav1.ObjectMeta{
Name: "sample-runtime",
OwnerReferences: []metav1.OwnerReference{
{
Kind: "Pod",
Name: "some-pod",
UID: types.UID("pod-uid"),
},
{
Kind: datav1alpha1.Datasetkind,
Name: "sample-runtime",
UID: uid,
},
},
},
wantUID: uid,
expectErr: false,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
gotUID, err := GetOwnerDatasetUIDFromRuntimeMeta(tt.meta)
if (err != nil) != tt.expectErr {
t.Errorf("GetOwnerDatasetUIDFromRuntimeMeta() error = %v, expectErr %v", err, tt.expectErr)
return
}
if gotUID != tt.wantUID {
t.Errorf("GetOwnerDatasetUIDFromRuntimeMeta() uid = %v, want %v", gotUID, tt.wantUID)
}
})
}
}
Loading