Skip to content

fix(webhook): preserve required affinity branch semantics #5757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hxrshxz wants to merge 4 commits into
base: master
Choose a base branch
from
+596 −15

fix(webhook): preserve required affinity branch semantics

b7b4a61
Select commit
Loading
Failed to load commit list.
Draft

fix(webhook): preserve required affinity branch semantics #5757

fix(webhook): preserve required affinity branch semantics
b7b4a61
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 2, 2026 in 30s

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
61.4% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 470 in pkg/utils/webhook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "%s InjectNodeSelectorTerms failure, want:%v, got:%v" 5 times. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6vP7R0-edR1iPBS&open=AZ1Nq6vP7R0-edR1iPBS&pullRequest=5757

Check failure on line 45 in pkg/utils/webhook.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6ro7R0-edR1iPBQ&open=AZ1Nq6ro7R0-edR1iPBQ&pullRequest=5757

Check failure on line 329 in pkg/webhook/plugins/nodeaffinitywithcache/node_affinity_with_cache_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "node-a" 4 times. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6vh7R0-edR1iPBZ&open=AZ1Nq6vh7R0-edR1iPBZ&pullRequest=5757

Check failure on line 391 in pkg/utils/webhook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "metadata.name" 4 times. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6vP7R0-edR1iPBT&open=AZ1Nq6vP7R0-edR1iPBT&pullRequest=5757

Check failure on line 195 in pkg/webhook/plugins/nodeaffinitywithcache/node_affinity_with_cache_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "fluid.io/dataset." 4 times. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6vh7R0-edR1iPBa&open=AZ1Nq6vh7R0-edR1iPBa&pullRequest=5757

Check failure on line 134 in pkg/webhook/plugins/requirenodewithfuse/require_node_with_fuse_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "us-east-1" 4 times. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6v17R0-edR1iPBb&open=AZ1Nq6v17R0-edR1iPBb&pullRequest=5757

Check failure on line 103 in pkg/webhook/plugins/requirenodewithfuse/require_node_with_fuse_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "fluid.io/fuse" 4 times. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1KzDXZHZwaKbLfBuTa&open=AZ1KzDXZHZwaKbLfBuTa&pullRequest=5757

Check failure on line 301 in pkg/utils/webhook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "us-east-1" 6 times. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6vP7R0-edR1iPBU&open=AZ1Nq6vP7R0-edR1iPBU&pullRequest=5757

Check failure on line 282 in pkg/utils/webhook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "fluid.io/fuse" 6 times. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6vP7R0-edR1iPBV&open=AZ1Nq6vP7R0-edR1iPBV&pullRequest=5757

Check failure on line 195 in pkg/webhook/plugins/nodeaffinitywithcache/node_affinity_with_cache_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal ".sched" 4 times. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6vh7R0-edR1iPBX&open=AZ1Nq6vh7R0-edR1iPBX&pullRequest=5757

Check failure on line 327 in pkg/webhook/plugins/nodeaffinitywithcache/node_affinity_with_cache_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "kubernetes.io/hostname" 4 times. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6vh7R0-edR1iPBY&open=AZ1Nq6vh7R0-edR1iPBY&pullRequest=5757

Check failure on line 73 in pkg/utils/webhook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 31 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6vP7R0-edR1iPBW&open=AZ1Nq6vP7R0-edR1iPBW&pullRequest=5757

Check failure on line 100 in pkg/utils/webhook_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "test-label-value" 4 times. 

See more on https://sonarcloud.io/project/issues?id=fluid-cloudnative_fluid&issues=AZ1Nq6vP7R0-edR1iPBR&open=AZ1Nq6vP7R0-edR1iPBR&pullRequest=5757
View more details on SonarQubeCloud