Repository navigation
Conversation
tchoutri
force-pushed
the
329-show-system-dependencies-in-dependencies-page
branch
from
October 31, 2026 22:09
3946b2e to
a13fee1
Compare
tchoutri
marked this pull request as draft
October 31, 2026 22:12
tchoutri
force-pushed
the
329-show-system-dependencies-in-dependencies-page
branch
from
November 1, 2026 10:21
a13fee1 to
57f4ba6
Compare
tchoutri
commented
Nov 1, 2026
Comment on lines
+13
to
+24
| .systemDependencies { | ||
| display: grid; | ||
| grid-template-columns: max-content max-content 1fr; | ||
| gap: var(--space-gutter-small) var(--space-gutter); | ||
| } | ||
|
|
||
| .systemDependencies > li { | ||
| display: grid; | ||
| grid-column: 1 / -1; | ||
| grid-template-columns: subgrid; | ||
| align-items: center; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Not super confident about this grid layout…
tchoutri
commented
Nov 1, 2026
Comment on lines
+49
to
+61
| instance Display (Condition ConfVar) where | ||
| displayBuilder = displayBuilder . go TopLevel | ||
| where | ||
| go :: ConditionContext -> Condition ConfVar -> Text | ||
| go _ (Var confVar) = display confVar | ||
| go _ (Lit b) = if b then "true" else "false" | ||
| go _ (CNot condition) = "!" <> go InNegation condition | ||
| go context (CAnd left right) = | ||
| parenthesiseUnless (context `elem` [TopLevel, InConjunction]) $ | ||
| go InConjunction left <> " && " <> go InConjunction right | ||
| go context (COr left right) = | ||
| parenthesiseUnless (context `elem` [TopLevel, InDisjunction]) $ | ||
| go InDisjunction left <> " || " <> go InDisjunction right |
Contributor
Author
There was a problem hiding this comment.
Pity that Cabal-syntax doesn't seem to export those.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR displays system dependencies in a package's dependencies pages. The layout is tentative, as it doesn't handle well pathological cases like the case of
text's C++ dependency.Screenshots
cardano-crypto-classtextrtsContributor checklist