Repository navigation
Conversation
Contributor
Author
|
@elland @leana8959 sorry to bother you, I'd just like your input about this ADR. :) |
leana8959
reviewed
Nov 1, 2026
|
I wonder how there could be some link between:
|
Contributor
Author
|
I do find the usage of get-tested to quite reliably enforce |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered version: https://github.com/flora-pm/flora-server/blob/adr-0003-compiler-version-and-tested-with/architecture/0003-compiler-versions-and-tested-with.md
Today, Flora displays a list of "tested with" versions on the page of a package.
This data comes from a raw version expression in the cabal file. Flora expands
this expression to a list of known GHC versions that is hardcoded in the
codebase.
This design has these problems:
The hardcoded list lags behind the actual releases. It does not contain
9.12.3, 9.12.4, or the 9.14 series. As a result, we get tickets on GitHub
because a package page does not show all intended versions.
The stored result is frozen. A new GHC release does not show on old releases
until Flora imports them again.
Open ranges expand to many badges.
acceleratedeclarestested-with: GHC >= 8.6. Flora shows about 35 patch versions for it.This ADR aims to fix this problem by reworking how we get compiler information and how the releases we import are linked to the compilers their claim to support.