feat(settings): add password meter#1299
Open
FromSi wants to merge 3 commits into
Open
Conversation
floatpanebot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds real-time password feedback to the encryption settings screen.
weak,medium, orstrong.internal/passwordstrengthwith aMeterinterface and aLibMeterimplementation backed bygithub.com/wagslane/go-password-validator.Why?
Closes #628
Users previously only learned that password confirmation failed after submitting the form. Inline feedback makes the encryption setup flow clearer and helps users catch mistakes before attempting to enable encryption.
The strength meter is informational only: weak passwords are not rejected.
Demo password used in the attached GIF:
CorrectHorseBatteryStaple1!