test(i18n): cover ParseLocale cases#1293
Merged
andrinoff merged 2 commits intoMay 18, 2026
Merged
Conversation
Signed-off-by: superShen0916 <superShen0916@users.noreply.github.com>
floatpanebot
previously requested changes
May 15, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @superShen0916! Please fix the following issues with your PR:
- Body: Missing the
## What?or## Why?headings required by the PR template.
floatpanebot
added
bug
floatpanebot
dismissed
their stale review
Formatting issues have been resolved. Thank you!
Member
|
@superShen0916 You added no RTL test case, please add the test. |
Signed-off-by: superShen0916 <superShen0916@users.noreply.github.com>
andrinoff
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds table-driven tests for
ParseLocalecovering:Why?
ParseLocaleis a small public i18n helper with no dedicated tests. The new tests lock down locale normalization, fallback direction, and invalid-input behavior before more locale work is added.Fixes #1075
Tests
go test ./i18ngo test ./...