Accept ID or URI on account functions#4
Open
josephwegner wants to merge 2 commits into
Open
Conversation
added 2 commits
December 19, 2012 22:48
Owner
|
Hey Joesph, sorry about the delay, got busy with the holidays. Will check these out and pull them in as asap, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works for marketplace (and everything else) too.. But none of those functions require IDs yet.
The getId implementation I'm using feels a bit hacky, but it's significantly more efficient than the other alternatives I could think of. We may have to refactor it if the API specs change in the future... But that would be true one way or another.