Repository navigation
Allow tag refs for GitHub-owned actions in CodeRabbit config - #61
Conversation
The CI/CD security rule blanket-required SHA pinning for all actions, causing CodeRabbit to flag GitHub-owned actions (actions/checkout@v4, actions/setup-python@v5) that intentionally use tag refs for readability. Update the rule to match our convention: tag refs for actions/*, SHA pins with version comments for third-party actions. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
WalkthroughUpdated inherited CI/CD security instructions in ChangesGitHub Actions pinning guidance
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
amir-yogev-gh
left a comment
There was a problem hiding this comment.
LGTM
I think this should go also into the other projects as well.
…tl#61) The CI/CD security rule blanket-required SHA pinning for all actions, causing CodeRabbit to flag GitHub-owned actions (actions/checkout@v4, actions/setup-python@v5) that intentionally use tag refs for readability. Update the rule to match our convention: tag refs for actions/*, SHA pins with version comments for third-party actions. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
.coderabbit.yamlCI/CD security path instruction to distinguish GitHub-owned actions from third-party actionsactions/*) use tag refs (e.g.,@v4) for readability — no longer flagged for missing SHA pinsContext
CodeRabbit repeatedly flagged
actions/checkout@v4andactions/setup-python@v5with:This is a false positive for GitHub-owned actions, which we intentionally reference by tag. The blanket "pin by SHA" rule has been refined to match our actual convention.
Test plan
actions/checkout@v4oractions/setup-python@v5🤖 Generated with Claude Code
CI/CD Security Guidelines Update
Updated the CodeRabbit CI/CD security guidance in
.coderabbit.yamlfor GitHub Actions pinning conventions. The change refines the inherited security rules that apply to all workflows in.github/workflows/**/*.Behavioral Change:
actions/*): Now permitted to use tag refs (e.g.,@v4) without SHA pinning. These will no longer be flagged as security violations during CodeRabbit reviews.@<sha> # v1.2.3).This replaces the previous blanket "pin all actions by SHA" rule, eliminating false positives on widely-used GitHub-maintained actions like
actions/checkoutandactions/setup-pythonwhile maintaining security requirements for external dependencies.Impact Scope: