Draft
Conversation
Zed + Opus 4.6; prompt: Run `make lint-js`. You'll get a lot of warnings back. Fix _at least_ the easiest 20%.
Zed + Opus 4.6; prompt: Resolve the low-hanging fruit on `no-explicit-any`. Goal is to cut the number of warnings there in half.
Zed + Opus 4.6, same conversation as the primary commit; prompt: Nice. Next up, fix the `consistent-return` issues.
Zed + Opus 4.6, same conversation as previous commit; prompt: Next, fix the `react/no-unused-prop-types` warnings.
Zed + Opus 4.6, same conversation as previous commit; prompt: Next, fix the `react-hooks/exhaustive-deps` issues
Zed + Opus 4.6 from same conversation as last commit; prompt: Next, fix the `@typescript-eslint/no-non-null-assertion` issues
Zed + Opus 4.6; prompt: Next, fix no-constant-condition and no-alert issues, then react/no-danger, at which point we should have a clean linting run
Zed + Opus 4.6; prompt: Tests are broken on this branch right now, including an OOM. See job-logs.txt for more details (particularly toward the end of the file). Fix the issues so tests pass.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #43387 +/- ##
==========================================
- Coverage 66.88% 66.88% -0.01%
==========================================
Files 2591 2592 +1
Lines 207684 207709 +25
Branches 9286 9224 -62
==========================================
+ Hits 138913 138918 +5
- Misses 56136 56156 +20
Partials 12635 12635
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| interface IAppProps { | ||
| children: JSX.Element; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
| const [addedSoftwareToken, setAddedSoftwareToken] = useState<string | null>( | ||
| null | ||
| ); | ||
| const [addedSoftwareToken] = useState<string | null>(null); |
Member
There was a problem hiding this comment.
why is this a use state then, double check.
| <SoftwareAndroidForm | ||
| onSubmit={onAddSoftware} | ||
| onCancel={goBackToSoftwareTitles} | ||
| onClickPreviewEndUserExperience={onClickPreviewEndUserExperience} |
Member
There was a problem hiding this comment.
look to see if this was intentional
| onSubmit, | ||
| isLoading = false, | ||
| onCancel, | ||
| onClickPreviewEndUserExperience, |
Member
There was a problem hiding this comment.
look to see if this was intentional
| setLastEditedQueryDiscardData(DEFAULT_QUERY.discard_data); | ||
| } | ||
| }, [queryId]); | ||
| }, [ |
Member
There was a problem hiding this comment.
will need to go through all use effect dependencies, I vaguely remember adverse effects many moons ago
| hostStatusWebhookHostPercentage, | ||
| (val) => `${val}%` | ||
| ), | ||
| // intentionally omit dependency so options only computed initially |
Member
There was a problem hiding this comment.
this. So will need to fix accordingly
| // it's safe to assume that frequency is a number | ||
| (frequency: number | string) => `${frequency as number} days` | ||
| ), | ||
| // intentionally leave activityExpiryWindow out of the dependencies, so that the custom |
Member
There was a problem hiding this comment.
this. So will need to fix accordingly
| {} | ||
| ); | ||
| const [error, setError] = useState<Error | null>(null); | ||
| const [error] = useState<Error | null>(null); |
|
|
||
| // Create a simple mock SVG component for matched icons | ||
| const MockSvgIcon = ({ width, height, className }: any) => ( | ||
| /* eslint-disable react/prop-types */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.