Conversation
georgekarrv
requested review from
a team,
BCTBB,
ddribeiro,
ksatter and
rfairburn
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
WalkthroughThis pull request bumps the Fleet application version from v4.83.0 to v4.83.1 across multiple configuration and deployment files. The Helm chart version increments from v6.8.8 to v6.8.9, with the appVersion updated to match the new Fleet release. Container image references are updated in Helm values, AWS Terraform variables, and GCP Terraform variables. The npm package version for fleetctl is also incremented. Additionally, documentation examples in the github-manage tool are updated to reflect the new milestone version. 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@infrastructure/dogfood/terraform/gcp/variables.tf`:
- Around line 70-73: The Terraform file has a missing closing brace for the
variable "image" block which breaks parsing; add the closing "}" to terminate
the variable "image" block before the next variable
"software_installers_bucket_name" declaration so that the "variable \"image\""
block is properly closed and Terraform can parse the subsequent "variable
\"software_installers_bucket_name\"" block.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 33f94a3b-7a65-4c82-8a63-c3b6b3d5725a
⛔ Files ignored due to path filters (1)
CHANGELOG.mdis excluded by!**/*.md
📒 Files selected for processing (6)
charts/fleet/Chart.yamlcharts/fleet/values.yamlinfrastructure/dogfood/terraform/aws/variables.tfinfrastructure/dogfood/terraform/gcp/variables.tftools/fleetctl-npm/package.jsontools/github-manage/cmd/gm/releases.go
| variable "image" { | ||
| default = "fleetdm/fleet:v4.83.0" | ||
| default = "fleetdm/fleet:v4.83.1" | ||
|
|
||
| variable "software_installers_bucket_name" { |
There was a problem hiding this comment.
Missing closing brace in variable "image" block breaks Terraform parsing.
Line 70 opens variable "image" but there is no matching } before Line 73 starts the next variable block. This is a syntax blocker.
🐛 Proposed fix
variable "image" {
default = "fleetdm/fleet:v4.83.1"
+}
variable "software_installers_bucket_name" {
default = "fleet-software-installers"
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| variable "image" { | |
| default = "fleetdm/fleet:v4.83.0" | |
| default = "fleetdm/fleet:v4.83.1" | |
| variable "software_installers_bucket_name" { | |
| variable "image" { | |
| default = "fleetdm/fleet:v4.83.1" | |
| } | |
| variable "software_installers_bucket_name" { |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@infrastructure/dogfood/terraform/gcp/variables.tf` around lines 70 - 73, The
Terraform file has a missing closing brace for the variable "image" block which
breaks parsing; add the closing "}" to terminate the variable "image" block
before the next variable "software_installers_bucket_name" declaration so that
the "variable \"image\"" block is properly closed and Terraform can parse the
subsequent "variable \"software_installers_bucket_name\"" block.
There was a problem hiding this comment.
@georgekarrv Why are they both flagging this? I know you're not changing that line so it must be fine, but I wonder if the indentation is throwing them off?
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates repo references to Fleet v4.83.1 and documents the release in the changelog.
Changes:
- Bumped Fleet version references across tooling, Helm chart, and dogfood Terraform defaults.
- Updated
gm releases forecastmilestone example to 4.83.1. - Added Fleet 4.83.1 changelog section.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/github-manage/cmd/gm/releases.go | Updates milestone example string for forecasting. |
| tools/fleetctl-npm/package.json | Bumps fleetctl npm package version to v4.83.1. |
| infrastructure/dogfood/terraform/gcp/variables.tf | Updates default Fleet image tag to v4.83.1. |
| infrastructure/dogfood/terraform/aws/variables.tf | Updates default Fleet image tag to v4.83.1. |
| charts/fleet/values.yaml | Updates Helm values default image tag to v4.83.1. |
| charts/fleet/Chart.yaml | Bumps chart version and appVersion to v4.83.1. |
| CHANGELOG.md | Adds 4.83.1 entry; modifies older entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| variable "image" { | ||
| default = "fleetdm/fleet:v4.83.0" | ||
| default = "fleetdm/fleet:v4.83.1" |
There was a problem hiding this comment.
variable "image" is missing its closing } before the next variable block begins, which will make this Terraform file fail to parse. Close the image variable block before declaring software_installers_bucket_name.
| default = "fleetdm/fleet:v4.83.1" | |
| default = "fleetdm/fleet:v4.83.1" | |
| } |
| - Fixed stale software titles list after deleting a software installer. | ||
| - Fixed query results cleanup cron failing with "too many placeholders" error by filtering to only saved queries and batching the SQL IN clause. | ||
|
|
||
| ## Fleet 4.81.3 (Mar 20, 2026) | ||
|
|
||
| ### Bug fixes | ||
|
|
||
| - Added configurable body size limits for the `/api/osquery/log` and `/api/osquery/distributed/write` endpoints. | ||
| - Fixed false positive `PayloadTooLargeError` errors. | ||
|
|
||
| ## Fleet 4.81.2 (Mar 06, 2026) |
There was a problem hiding this comment.
This change removes the Fleet 4.81.3 section (it no longer appears between 4.83.0 and 4.81.2). Since the PR is scoped to “Adding changes for Fleet v4.83.1”, deleting an older released section looks unintended; please restore the 4.81.3 entry unless there’s a specific reason to drop it.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43357 +/- ##
==========================================
- Coverage 66.89% 66.87% -0.02%
==========================================
Files 2588 2588
Lines 207563 207563
Branches 9207 9207
==========================================
- Hits 138840 138805 -35
- Misses 56096 56122 +26
- Partials 12627 12636 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit