Skip to content

Show disabled refetch button with tooltip for Android hosts #42165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kilo-code-bot wants to merge 5 commits into
base: main
Choose a base branch
from
+48 −14
Draft

Show disabled refetch button with tooltip for Android hosts #42165

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1badbd2
Show disabled refetch button with tooltip for Android hosts
kilo-code-bot[bot] Mar 20, 2026
73d0dcc
Update Android refetch tooltip to mention Google rate limiting
kilo-code-bot[bot] Mar 20, 2026
2b6ea37
Update Android refetch tooltip text and add link to manual sync docs
kilo-code-bot[bot] Mar 23, 2026
ee3f70e
Apply suggestions from code review
noahtalerman Apr 9, 2026
5d1ccf7
Add route for Android manual sync guide
noahtalerman Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions frontend/pages/hosts/details/cards/HostHeader/HostHeader.tests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,23 @@ describe("HostHeader", () => {
expect(screen.getByText("My device")).toBeInTheDocument();
expect(screen.getByText(/unavailable/i)).toBeInTheDocument();
});
it("does not render refetch button for Android", () => {
render(
it("renders a disabled refetch button with tooltip for Android", async () => {
const { user } = renderWithSetup(
<HostHeader
summaryData={{ ...defaultSummaryData, platform: "android" }}
showRefetchSpinner={false}
onRefetchHost={jest.fn()}
renderActionsDropdown={renderActionDropdown}
/>
);
expect(screen.queryByText("Refetch")).not.toBeInTheDocument();
const refetchButton = screen.getByRole("button", { name: /refetch/i });
expect(refetchButton).toBeDisabled();

await user.hover(screen.getByText("Refetch"));

expect(
await screen.findByText(/Android devices sync automatically/i)
).toBeInTheDocument();
});

it("disables refetch button when host is offline", () => {
Expand Down
9 changes: 8 additions & 1 deletion frontend/pages/hosts/details/cards/HostHeader/HostHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,14 @@ const HostHeader = ({

const renderRefetch = () => {
if (isAndroid(platform)) {
return null;
return (
<RefetchButton
isDisabled
isFetching={false}
tooltip={REFETCH_TOOLTIP_MESSAGES.android}
onRefetchHost={onRefetchHost}
/>
);
}

const isOnline = summaryData.status === "online";
Expand Down
11 changes: 10 additions & 1 deletion frontend/pages/hosts/details/cards/HostHeader/helpers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,18 @@ export const DEVICE_STATUS_TAGS: DeviceStatusTagConfig = {

// We exclude "unlocked" as we dont display a tooltip for it.
export const REFETCH_TOOLTIP_MESSAGES: Record<
HostMdmDeviceStatusUIStateNoUnlock | "offline",
HostMdmDeviceStatusUIStateNoUnlock | "offline" | "android",
JSX.Element
> = {
android: (
<>
Android devices sync automatically. To manually
<br />
sync, go to <b>Settings &gt; Google &gt; Work profile</b>
<br />
<b>&gt; Device policy</b> on the device.
</>
),
offline: (
<>
You can&apos;t fetch data from <br /> an offline host.
Expand Down
Loading