Add repro for GitOps inline script backslash-escape stripping bug#114
Closed
Add repro for GitOps inline script backslash-escape stripping bug#114
Conversation
Adds a minimal macOS self-service package on the Workstations team that references an inline install script containing common bash variables (\$EUID, \$USER, \$HOME, \$CURRENT_USER) in their escaped form. GitOps validation requires the backslash escape so Fleet does not try to resolve these as repo-level environment variables at ingestion time. The expectation is that Fleet strips the leading backslash before delivering the script to the host. If the install script visible in Fleet UI (Software > package > Advanced options > Install script) or delivered at install time still contains the literal backslashes, the unescape step is missing and bash on the target host will error out with "\$EUID: command not found". https://claude.ai/code/session_01BWXRyfu3TSmcG3bZfBjQnE
AdamBaali
requested review from
allenhouchins,
getvictor,
lukeheath and
noahtalerman
as code owners
Member
Author
|
Sorry meant to test on my repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a minimal macOS self-service package on the Workstations team that
references an inline install script containing common bash variables
($EUID, $USER, $HOME, $CURRENT_USER) in their escaped form.
GitOps validation requires the backslash escape so Fleet does not try
to resolve these as repo-level environment variables at ingestion time.
The expectation is that Fleet strips the leading backslash before
delivering the script to the host. If the install script visible in
Fleet UI (Software > package > Advanced options > Install script) or
delivered at install time still contains the literal backslashes, the
unescape step is missing and bash on the target host will error out
with "$EUID: command not found".
https://claude.ai/code/session_01BWXRyfu3TSmcG3bZfBjQnE