fix: Add descriptive toString to ParsingException and test empty image layers - #99
Open
spydon wants to merge 2 commits into
Open
fix: Add descriptive toString to ParsingException and test empty image layers#99spydon wants to merge 2 commits into
toString to ParsingException and test empty image layers#99spydon wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes out the two remaining parts of #92.
The crash itself (an
<imagelayer>without an<image>child throwing) was already fixed in #72, where the image layer parser started usingTiledImage.parseOrNull(parser) ?? const TiledImage(). This PR adds regression tests for that case in both TMX and JSON so it stays fixed.The second complaint in the issue was that the error surfaced as
Instance of 'ParsingException', which gives the user nothing to go on.ParsingExceptionalready carriesname,valueFound, andreason, so this PR adds atoString()that uses them:Tests cover the message format with and without a found value, and an end-to-end check that a map missing a required attribute throws a
ParsingExceptionnaming that field.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues
Fixes #92