Remove fallback of register gems - #280
Open
cyber-pioneer wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the get_name() identifier for the FlagGems attention backend implementation (AttentionFLBackend) under vllm_fl.dispatch.backends.flaggems, which is used as part of the attention-backend dispatch/registration flow.
Changes:
- Renames
AttentionFLBackend.get_name()return value from"FL"to"CUSTOM".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+76
to
+77
| def get_name() -> str: | ||
| return "FL" | ||
| return "CUSTOM" |
Comment on lines
137
to
+141
| # Register FlagGems (DEFAULT) implementations | ||
| try: | ||
| from .backends.flaggems.register_ops import register_builtins as register_flaggems | ||
| from .backends.flaggems.register_ops import register_builtins as register_flaggems | ||
|
|
||
| register_flaggems(registry) | ||
| logger.info("Registered FlagGems operators") |
Comment on lines
144
to
+148
| # Register PyTorch (REFERENCE) implementations | ||
| try: | ||
| from .backends.reference.register_ops import register_builtins as register_reference | ||
| from .backends.reference.register_ops import register_builtins as register_reference | ||
|
|
||
| register_reference(registry) | ||
| logger.debug("Registered Reference operators") | ||
| except Exception as e: | ||
| logger.warning(f"Failed to register Reference operators: {e}") | ||
| register_reference(registry) | ||
| logger.info("Registered Reference operators") |
Comment on lines
+75
to
+77
| @staticmethod | ||
| def get_name() -> str: | ||
| return "FL" | ||
| return "CUSTOM" |
Comment on lines
+138
to
+141
| from .backends.flaggems.register_ops import register_builtins as register_flaggems | ||
|
|
||
| register_flaggems(registry) | ||
| logger.info("Registered FlagGems operators") |
Comment on lines
+145
to
+148
| from .backends.reference.register_ops import register_builtins as register_reference | ||
|
|
||
| register_reference(registry) | ||
| logger.debug("Registered Reference operators") | ||
| except Exception as e: | ||
| logger.warning(f"Failed to register Reference operators: {e}") | ||
| register_reference(registry) | ||
| logger.info("Registered Reference operators") |
Comment on lines
137
to
+141
| # Register FlagGems (DEFAULT) implementations | ||
| try: | ||
| from .backends.flaggems.register_ops import register_builtins as register_flaggems | ||
| from .backends.flaggems.register_ops import register_builtins as register_flaggems | ||
|
|
||
| register_flaggems(registry) | ||
| logger.info("Registered FlagGems operators") |
cyber-pioneer
force-pushed
the
fix_attn_name
branch
from
July 14, 2026 10:51
ca80260 to
f1b93cc
Compare
Comment on lines
+138
to
+141
| from .backends.flaggems.register_ops import register_builtins as register_flaggems | ||
|
|
||
| register_flaggems(registry) | ||
| logger.info("Registered FlagGems operators") |
| from .backends.flaggems.register_ops import register_builtins as register_flaggems | ||
|
|
||
| register_flaggems(registry) | ||
| logger.info("Registered FlagGems operators") |
Comment on lines
142
to
144
|
|
||
| register_flaggems(registry) | ||
| logger.debug("Registered FlagGems operators") | ||
| except Exception as e: | ||
| logger.warning(f"Failed to register FlagGems operators: {e}") | ||
|
|
||
| # Register PyTorch (REFERENCE) implementations |
| except Exception as e: | ||
| logger.warning(f"Failed to register Reference operators: {e}") | ||
| register_reference(registry) | ||
| logger.info("Registered Reference operators") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Vendor
PR Type
Bug Fixes
Description
match attention name into https://github.com/vllm-project/vllm/blob/v0.20.2/vllm/v1/attention/backends/registry.py#L34