[TLE][MTHREADS] Fix shared memory alias conflict for tle.gpu.alloc bu…#849
Open
Kylin1207 wants to merge 1 commit into
Open
[TLE][MTHREADS] Fix shared memory alias conflict for tle.gpu.alloc bu…#849Kylin1207 wants to merge 1 commit into
Kylin1207 wants to merge 1 commit into
Conversation
…ffers The mthreads backend's Alias.cpp overrode the common implementation but lacked TLE alias propagation for tle.local_pointers and pointer-arithmetic chains (tt.splat / tt.addptr). This caused the shared-memory allocator to believe that a tle.gpu.alloc buffer was dead after the tle.local_pointers op, allowing scratch allocations to overlap with the still-live buffer and corrupt subsequent loads. Fix flagos-ai#836.
Kylin1207
requested review from
Galaxy1458,
menchunlei,
sunnycase and
zhzhcookie
as code owners
July 25, 2026 06:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mthreads backend's Alias.cpp overrode the common implementation but lacked TLE alias propagation for tle.local_pointers and pointer-arithmetic chains (tt.splat / tt.addptr). This caused the shared-memory allocator to believe that a tle.gpu.alloc buffer was dead after the tle.local_pointers op, allowing scratch allocations to overlap with the still-live buffer and corrupt subsequent loads.
Fix #836.