[MAINTENANCE] Add a BigQuery integration test for bundled metric alias collisions - #12025
Open
joshua-stauffer wants to merge 1 commit into
Open
[MAINTENANCE] Add a BigQuery integration test for bundled metric alias collisions#12025joshua-stauffer wants to merge 1 commit into
joshua-stauffer wants to merge 1 commit into
Conversation
Validating a suite whose expectations resolve to the same metric name produces a single bundled query with one column alias per metric. Those aliases are currently identical, which backends that reject duplicate output column names refuse to compile.
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Contributor
|
Hii @joshua-stauffer I saw the BigQuery CI passed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a single BigQuery integration test that validates an expectation suite whose expectations all resolve to the same metric name (
column_values.nonnull.unexpected_counton three different columns).This test is expected to fail on
develop. It is being pushed to confirm that BigQuery reproduces the duplicate-alias failure described in #10926, so the fix proposed in #11905 can be validated against a backend that actually rejects the query.Why
The SQL execution engine bundles the metrics a suite needs into as few queries as possible. Expectations on different columns can resolve to the same metric name, and today every one of them is labeled with that bare metric name — so a bundled query emits several identical output column aliases:
Permissive backends (SQLite, Postgres) accept that; strict ones reject the query outright. ClickHouse is currently worked around with a dialect-specific random-suffix branch in
_organize_metrics_by_domain; the question this test answers is whether BigQuery needs the same treatment, which would argue for making the deduplication general rather than dialect-specific.User impact
None — test-only change, no library code is touched.
How to review
Check the
marker-tests (bigquery, ...)job. A failure there is the intended signal: it confirms BigQuery rejects the bundled query. If it passes, BigQuery tolerates duplicate aliases and the reproduction needs another angle.Note this PR is intentionally open as non-draft: the marker test jobs are gated on
github.event.pull_request.draft == false, so BigQuery CI does not run otherwise.