Skip to content

Support strftime format expectation gallery metadata - #12005

Closed
tarun-bandi wants to merge 1 commit into
fivetran:developfrom
tarun-bandi:agent/strftime-format-supported-expectation
Closed

Support strftime format expectation gallery metadata#12005
tarun-bandi wants to merge 1 commit into
fivetran:developfrom
tarun-bandi:agent/strftime-format-supported-expectation

Conversation

@tarun-bandi

Copy link
Copy Markdown

Summary

Closes #12004.

This brings ExpectColumnValuesToMatchStrftimeFormat up to the supported expectation/gallery surface for the engines it already implements:

  • adds gallery metadata, supported data source metadata, and schema extras
  • declares Pandas and Spark support while documenting SQL as out of scope for now
  • adds the generated schema file and includes the expectation in tasks.py
  • expands integration coverage from Spark-only to Pandas + Spark while preserving the timezone-aware %z regression case

Validation

  • PYTHONPYCACHEPREFIX=/Users/bandi/Documents/Codex/2026-07-24/new-chat/work/.pycache python3 -m py_compile great_expectations/expectations/core/expect_column_values_to_match_strftime_format.py tests/integration/data_sources_and_expectations/expectations/test_expect_column_values_to_match_strftime_format.py tasks.py
  • python3 -m json.tool great_expectations/expectations/core/schemas/ExpectColumnValuesToMatchStrftimeFormat.json
  • git diff --cached --check

I attempted to generate the schema through the local model import path, but this stripped workspace hit an unrelated SciPy/native import failure while importing the full expectation package.

@netlify

netlify Bot commented Jul 25, 2026

Copy link
Copy Markdown

👷 Deploy request for niobium-lead-7998 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c777d34

@github-actions github-actions Bot added the cla-not-signed https://github.com/fivetran/great_expectations/blob/develop/CLA.md label Jul 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Before we can merge this pull request, every committer needs to have signed our Contributor License Agreement (CLA).

We could not find a signed CLA for: @tarun-bandi. Please sign the Individual Contributor License Agreement, or the Software Grant and Corporate Contributor License Agreement if you are contributing on behalf of your employer (see CLA.md for details).

Once resolved, comment @cla-bot check on this pull request to re-run the check.

@joshua-stauffer

Copy link
Copy Markdown
Collaborator

hey @tarun-bandi, thanks for the PR. Looks like we're still missing a CLA from you, and there's another PR open for the same issue which is ready to merge. I'll close this now in favor of #12009, but would welcome a contribution in the future. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-not-signed https://github.com/fivetran/great_expectations/blob/develop/CLA.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make ExpectColumnValuesToMatchStrftimeFormat a fully-supported, Gallery-published Expectation

2 participants