Repository navigation
fix: disable database query echo by default - #696
Closed
Akshay7483 wants to merge 1 commit into
Closed
Akshay7483 wants to merge 1 commit into
Akshay7483 wants to merge 1 commit into
Conversation
Author
|
Thanks for reviewing! I’ve tested the configuration locally and verified that SQL query echoing is disabled by default while still allowing it to be enabled explicitly with FIREFORM_DB_ECHO=true. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FIREFORM_DB_ECHO=trueavailable for explicitly enabling SQL query logging.Testing
DB_ECHO = FalsewhenFIREFORM_DB_ECHOis unset.DB_ECHO = TruewhenFIREFORM_DB_ECHO=true.docker/dev/compose.ymlwithdocker compose config.git diff --cached --checksuccessfully.