Skip to content

Keep a consistent labeling of boundaries for 2D periodic meshes#5005

Open
connorjward wants to merge 3 commits intomainfrom
connorjward/break-periodic-api
Open

Keep a consistent labeling of boundaries for 2D periodic meshes#5005
connorjward wants to merge 3 commits intomainfrom
connorjward/break-periodic-api

Conversation

@connorjward
Copy link
Copy Markdown
Contributor

This PR changes the labels of 2D periodic meshes so that they always resemble

    4
 +-----+
 |     |
1|     |2
 |     |
 +-----+
    3

regardless of periodicity (some labels can be empty). This contrasts with the current solution where the boundary labels are

    2
 +-----+
 |     |
 |     |
 |     |
 +-----+
    1

or

 +-----+
 |     |
1|     |2
 |     |
 +-----+

depending on the direction of periodicity.

This is useful to do because:

  • It's more intuitive, the old solution only existed because of how we generated periodic meshes via higher-dimensional manifold meshes.
  • It lets us discard some tricky hacks

This is unfortunately and unavoidably an immediately breaking change but we at least warn users if they try to use an empty boundary set.

Comment thread tests/firedrake/regression/test_periodic_2d.py Outdated
Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
Comment thread tests/firedrake/regression/test_periodic_2d.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants