Keep a consistent labeling of boundaries for 2D periodic meshes#5005
Open
connorjward wants to merge 3 commits intomainfrom
Open
Keep a consistent labeling of boundaries for 2D periodic meshes#5005connorjward wants to merge 3 commits intomainfrom
connorjward wants to merge 3 commits intomainfrom
Conversation
pbrubeck
reviewed
Mar 31, 2026
Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
connorjward
commented
Apr 1, 2026
dham
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the labels of 2D periodic meshes so that they always resemble
regardless of periodicity (some labels can be empty). This contrasts with the current solution where the boundary labels are
or
depending on the direction of periodicity.
This is useful to do because:
This is unfortunately and unavoidably an immediately breaking change but we at least warn users if they try to use an empty boundary set.