Skip to content

Refactor PCPatch code to not use PyOP2 #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connorjward wants to merge 19 commits into
base: main
Choose a base branch
from
+630 −690
Open

Refactor PCPatch code to not use PyOP2 #4993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9edd899
Initial refactor ideas
connorjward Mar 25, 2026
439f1c2
This partially works now
connorjward Mar 25, 2026
e0d74a2
fixup
connorjward Mar 26, 2026
04f1093
cleanup
connorjward Mar 26, 2026
6994f3f
things are working
connorjward Mar 26, 2026
cb29c59
some cleanup
connorjward Mar 26, 2026
ee31879
Commentary
connorjward Mar 26, 2026
98afa77
wip
connorjward Mar 27, 2026
12d8b91
Add missing PetscFunctionBegin calls to tinyASM
connorjward Mar 27, 2026
6b4509b
Store refs
connorjward Mar 27, 2026
85fc57d
Prep for SNESPatch, still fairly tidy looking
connorjward Mar 27, 2026
2f95da8
Merge branch 'main' into connorjward/patch-refactor
connorjward Mar 27, 2026
b976dbe
Residuals nearly there, more state work needed
connorjward Mar 27, 2026
6c73411
SNES fixes, now just seeing GC errors and exterior facets?
connorjward Mar 29, 2026
baed8e6
ext facet fix and cleanup
connorjward Mar 29, 2026
02fc095
fixes, still segfaulting
connorjward Mar 30, 2026
43938b3
fixup
connorjward Mar 30, 2026
5eb8d99
fixups
connorjward Mar 30, 2026
2a0f7b7
cleanup
connorjward Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 29 additions & 42 deletions firedrake/cython/patchimpl.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,45 +2,32 @@ from libc.stdint cimport uintptr_t

include "petschdr.pxi"

def set_patch_residual(patch, function, ctx, is_snes=False, interior_facets=False, exterior_facets=False):
if is_snes:
if interior_facets or exterior_facets:
raise NotImplementedError
CHKERR(SNESPatchSetComputeFunction((<PETSc.SNES?>patch).snes,
<PetscPCPatchComputeFunction><uintptr_t>function,
<void *><uintptr_t>ctx))
else:
if interior_facets:
CHKERR(PCPatchSetComputeFunctionInteriorFacets((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeFunction><uintptr_t>function,
<void *><uintptr_t>ctx))
elif exterior_facets:
CHKERR(PCPatchSetComputeFunctionExteriorFacets((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeFunction><uintptr_t>function,
<void *><uintptr_t>ctx))
else:
CHKERR(PCPatchSetComputeFunction((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeFunction><uintptr_t>function,
<void *><uintptr_t>ctx))
Comment on lines -13 to -24
Copy link
Copy Markdown
Contributor Author

@connorjward connorjward Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions were never called



def set_patch_jacobian(patch, function, ctx, is_snes=False, interior_facets=False, exterior_facets=False):
if is_snes:
if interior_facets or exterior_facets:
raise NotImplementedError
CHKERR(SNESPatchSetComputeOperator((<PETSc.SNES?>patch).snes,
<PetscPCPatchComputeOperator><uintptr_t>function,
<void *><uintptr_t>ctx))
else:
if interior_facets:
CHKERR(PCPatchSetComputeOperatorInteriorFacets((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeOperator><uintptr_t>function,
<void *><uintptr_t>ctx))
elif exterior_facets:
CHKERR(PCPatchSetComputeOperatorExteriorFacets((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeOperator><uintptr_t>function,
<void *><uintptr_t>ctx))
else:
CHKERR(PCPatchSetComputeOperator((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeOperator><uintptr_t>function,
<void *><uintptr_t>ctx))

def pcpatch_set_compute_operator(patch, function, ctx):
CHKERR(PCPatchSetComputeOperator((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeOperator><uintptr_t>function,
<void *><uintptr_t>ctx))


def pcpatch_set_compute_operator_interior_facets(patch, function, ctx):
CHKERR(PCPatchSetComputeOperatorInteriorFacets((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeOperator><uintptr_t>function,
<void *><uintptr_t>ctx))


def pcpatch_set_compute_operator_exterior_facets(patch, function, ctx):
CHKERR(PCPatchSetComputeOperatorExteriorFacets((<PETSc.PC?>patch).pc,
<PetscPCPatchComputeOperator><uintptr_t>function,
<void *><uintptr_t>ctx))


def snespatch_set_compute_operator(patch, function, ctx):
CHKERR(SNESPatchSetComputeOperator((<PETSc.SNES?>patch).snes,
<PetscPCPatchComputeOperator><uintptr_t>function,
<void *><uintptr_t>ctx))


def snespatch_set_compute_function(patch, function, ctx):
CHKERR(SNESPatchSetComputeFunction((<PETSc.SNES?>patch).snes,
<PetscPCPatchComputeFunction><uintptr_t>function,
<void *><uintptr_t>ctx))
Loading
Loading