Skip to content

feat(metrics): add optional id and properties fields to metrics output#5983

Merged
not4s merged 8 commits into
firecracker-microvm:mainfrom
not4s:feat/metrics-properties
Jul 3, 2026
Merged

feat(metrics): add optional id and properties fields to metrics output#5983
not4s merged 8 commits into
firecracker-microvm:mainfrom
not4s:feat/metrics-properties

test(metrics): add integration tests for id and properties

bd6f9f0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project/firecracker succeeded Jul 1, 2026 in 0s

83.12% (target 80.00%)

View this Pull Request on Codecov

83.12% (target 80.00%)

Details

Codecov Report

❌ Patch coverage is 92.45283% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.12%. Comparing base (e04e55f) to head (bd6f9f0).

Files with missing lines Patch % Lines
src/firecracker/src/main.rs 0.00% 2 Missing ⚠️
src/vmm/src/logger/metrics.rs 97.50% 1 Missing ⚠️
src/vmm/src/vmm_config/metrics.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5983      +/-   ##
==========================================
+ Coverage   83.11%   83.12%   +0.01%     
==========================================
  Files         277      277              
  Lines       30207    30259      +52     
==========================================
+ Hits        25106    25154      +48     
- Misses       5101     5105       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.