Skip to content

fix: preserve keepSynced state across Query.get - #8544

Open
mvanhorn wants to merge 1 commit into
firebase:mainfrom
mvanhorn:fix/8433-database-keep-synced-get
Open

fix: preserve keepSynced state across Query.get#8544
mvanhorn wants to merge 1 commit into
firebase:mainfrom
mvanhorn:fix/8433-database-keep-synced-get

Conversation

@mvanhorn

Copy link
Copy Markdown

Have the internal SyncTree.keepSynced operation report whether the requested transition actually added a registration, while retaining idempotent behavior for ordinary public keepSynced calls. Calling keepSynced(true) and get() on the same Realtime Database query can corrupt the SDK's internal keep-synced bookkeeping after the server response is applied.

With persistence disabled and no cached data, call keepSynced(true), await get(), call keepSynced(true) again for the same path, and await another get(); both tasks return the server value without a duplicate-listen assertion; Repeat the second synchronization and read through a newly created DatabaseReference for the same path to verify deduplication follows QuerySpec identity rather than Java object identity.

Fixes #8433

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Realtime Database Android: keepSynced(true) followed by get() causes AssertionError "listen() called twice for same QuerySpec"

1 participant