Skip to content

Bump ESLint to 10.8.1 and address new lint errors - #2127

Merged
kriswest merged 2 commits into
mainfrom
agent/bump-eslint-latest
Sep 9, 2026
Merged

Bump ESLint to 10.8.1 and address new lint errors#2127
kriswest merged 2 commits into
mainfrom
agent/bump-eslint-latest

Conversation

@julianna-ciq

@julianna-ciq julianna-ciq commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • updates ESLint from 9.39.5 to 10.8.1 and @eslint/js to 10.0.1 across every workspace that declares them
  • replaces the Workbench's ESLint-9-only import plugin with ESLint-10-compatible eslint-plugin-import-x
  • removes the Workbench React lint plugin, which only supplied an obsolete JSX bookkeeping rule and disabled rules
  • fixes the new ESLint 10 preserve-caught-error violation while retaining the existing failover error message
  • fixes the new ESLint 10 no-useless-assignment violation in Workbench context-copy naming

Supersedes #2120.

Why

ESLint 10 enables additional recommended correctness rules. The existing Workbench plugins also did not declare ESLint 10 compatibility, which left the dependency tree invalid when upgrading only the core ESLint package.

Validation

  • npm run lint — passes (79 pre-existing Workbench warnings remain)
  • npm ls eslint @eslint/js eslint-plugin-import-x --all — one deduplicated ESLint 10.8.1 tree, no invalid peers
  • npm run build --workspace @finos/fdc3-get-agent — passes
  • npm test --workspace @finos/fdc3-get-agent — 38 tests pass
  • Workbench and reference UI builds completed successfully during the full build

The full repository build/test commands still report the pre-existing missing json-canonicalize dependency in @finos/fdc3-security. An initial parallel full-test run also timed out starting the fdc3-standard Vitest workers; this is unrelated to ESLint and occurred under concurrent build/test load.

@netlify

netlify Bot commented Aug 17, 2026

Copy link
Copy Markdown

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit 1b304fe
🔍 Latest deploy log https://app.netlify.com/projects/fdc3/deploys/6a9105d307447f0008d4f7df
😎 Deploy Preview https://deploy-preview-2127.preview-fdc3.finos.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@julianna-ciq
julianna-ciq marked this pull request as ready for review August 17, 2026 12:41
@julianna-ciq
julianna-ciq requested a review from a team as a code owner August 17, 2026 12:41
@codecov-commenter

codecov-commenter commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (cb00631) to head (1b304fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2127   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files          73       73           
  Lines        4251     4253    +2     
  Branches      596      679   +83     
=======================================
+ Hits         4040     4042    +2     
  Misses        211      211           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kriswest kriswest added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 20, 2026
Roaders
Roaders previously approved these changes Aug 20, 2026
@kriswest
kriswest merged commit 6a378d5 into main Sep 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants