Bump ESLint to 10.8.1 and address new lint errors - #2127
Merged
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
julianna-ciq
marked this pull request as ready for review
August 17, 2026 12:41
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2127 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 73 73
Lines 4251 4253 +2
Branches 596 679 +83
=======================================
+ Hits 4040 4042 +2
Misses 211 211 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Roaders
previously approved these changes
Aug 20, 2026
8 tasks
Roaders
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@eslint/jsto 10.0.1 across every workspace that declares themeslint-plugin-import-xpreserve-caught-errorviolation while retaining the existing failover error messageno-useless-assignmentviolation in Workbench context-copy namingSupersedes #2120.
Why
ESLint 10 enables additional recommended correctness rules. The existing Workbench plugins also did not declare ESLint 10 compatibility, which left the dependency tree invalid when upgrading only the core ESLint package.
Validation
npm run lint— passes (79 pre-existing Workbench warnings remain)npm ls eslint @eslint/js eslint-plugin-import-x --all— one deduplicated ESLint 10.8.1 tree, no invalid peersnpm run build --workspace @finos/fdc3-get-agent— passesnpm test --workspace @finos/fdc3-get-agent— 38 tests passThe full repository build/test commands still report the pre-existing missing
json-canonicalizedependency in@finos/fdc3-security. An initial parallel full-test run also timed out starting the fdc3-standard Vitest workers; this is unrelated to ESLint and occurred under concurrent build/test load.