Repository navigation
e2e: sidebar_live names each row drawn again with the same words - #801
Merged
Merged
Conversation
Its failure said only how many rows were kept (14 of 15 in CI, every row locally). Now it names each row shown before that was drawn again saying the same, with its HTML then and now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
futurepaul
marked this pull request as ready for review
October 31, 2026 05:10
alexlwn123
approved these changes
Oct 31, 2026
alexlwn123
left a comment
Collaborator
There was a problem hiding this comment.
Pass at 92a2d4e17306e4a40a8785b674cbc231826cd4e3.
This adds actionable diagnostics to sidebar_live without changing its assertion: missing rows are named, and unchanged rows whose elements were replaced include their before/after HTML. I traced the returned detail through Browser::eval and Suite::ok to the failure log. The small, test-only change is appropriate for the purpose; I found no blocking regression.
CI check and all four e2e shards passed. Local validation: git diff --check passed; e2e was not rerun locally. The referenced external engineering-style file was unavailable on this machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only: shell-ui's
sidebar_livecheck ("the rows shown before are the same elements (patched in place)…") now names each row it lost when it fails. That's every row shown before that was drawn again with the same words, with its HTML when marked and now. Before, the failure said only "kept 14 of 15".Why
Not changed: the check's expectation, and any product code.
Complexity ledger: two more things kept per row in the check's page script (its HTML), and a
lostlist in its failure detail. No product change.🤖 Generated with Claude Code