Skip to content

e2e: sidebar_live names each row drawn again with the same words - #801

Merged
futurepaul merged 1 commit into
masterfrom
claude/sidebar-rows-kept
Oct 31, 2026
Merged

futurepaul merged 1 commit into
masterfrom
claude/sidebar-rows-kept

Conversation

@futurepaul

@futurepaul futurepaul commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Test-only: shell-ui's sidebar_live check ("the rows shown before are the same elements (patched in place)…") now names each row it lost when it fails. That's every row shown before that was drawn again with the same words, with its HTML when marked and now. Before, the failure said only "kept 14 of 15".

Why

Not changed: the check's expectation, and any product code.

Complexity ledger: two more things kept per row in the check's page script (its HTML), and a lost list in its failure detail. No product change.

🤖 Generated with Claude Code

Its failure said only how many rows were kept (14 of 15 in CI, every
row locally). Now it names each row shown before that was drawn again
saying the same, with its HTML then and now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@futurepaul futurepaul changed the title shell: a sidebar row keeps its element unless what it shows changed e2e: sidebar_live names each row drawn again with the same words Oct 31, 2026
@futurepaul
futurepaul marked this pull request as ready for review October 31, 2026 05:10

@alexlwn123 alexlwn123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass at 92a2d4e17306e4a40a8785b674cbc231826cd4e3.

This adds actionable diagnostics to sidebar_live without changing its assertion: missing rows are named, and unchanged rows whose elements were replaced include their before/after HTML. I traced the returned detail through Browser::eval and Suite::ok to the failure log. The small, test-only change is appropriate for the purpose; I found no blocking regression.

CI check and all four e2e shards passed. Local validation: git diff --check passed; e2e was not rerun locally. The referenced external engineering-style file was unavailable on this machine.

@futurepaul
futurepaul added this pull request to the merge queue Oct 31, 2026
Merged via the queue into master with commit d811ff2 Oct 31, 2026
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants