This repository was archived by the owner on Jul 14, 2026. It is now read-only.
Repository navigation
Harden fbrain transport and working-tree sync - #46
Closed
AustinKelsay wants to merge 11 commits into
Closed
AustinKelsay wants to merge 11 commits into
AustinKelsay wants to merge 11 commits into
Conversation
Contributor
Author
|
@CodeRabbit full review |
Contributor
Author
|
PR CodeRabbit fallback recorded: |
Contributor
Author
|
Hard-cut completed directly to main in 7473dc9, so this staging PR is now obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the rollout-critical fbrain path for issues #44 and #45 from PRD #43:
--server, saved working-tree URL,FINITE_BRAIN_SERVER_URL, then legacyFINITE_BRAIN_PUBLIC_BASE_URLhttp://to localhost/loopback and disabling redirectsIssues
Verification
cargo fmt --check && cargo check --workspace && cargo test --workspace && cargo clippy --workspace --all-targets -- -D warnings && cargo build && git diff --checkcargo test -p finite-brain-clicargo test -p finite-brain-server product_client_serves_spine_assets_and_confignode crates/finite-brain-server/src/product-client.test.jsnode scripts/verify-obsidian-product-client.mjshttp://127.0.0.1:4019with temp DB/tmp/fbrain-sync-smoke-final.LlHQ5M/finite-brain.sqlite3:auth login,vault create personal-final,open, create/update/deletehome/final.mdthroughsync now, finallatestSequence=3,conflicts=[]Review
nostr::JsonUtilimport finding was recorded as a false positive because clean workspace check/test/clippy pass without it.docs/feature-dev/2026-06-27-local-coderabbit-fbrain-transport-working-tree-sync.mdNotes
open,daemon start,daemon tick, andsync nowuse the real sync path.