Merged
Conversation
ZenGround0
requested review from
TippyFlitsUK,
anorth,
arajasek,
jennijuju,
jsoares,
kaitlin-beegle,
momack2 and
raulk
as code owners
jennijuju
reviewed
May 2, 2024
jennijuju
reviewed
May 2, 2024
mtrisic
reviewed
May 2, 2024
jennijuju
approved these changes
May 2, 2024
Member
|
PR 1000! |
ZenGround0
force-pushed
the
fip-0090/future-proof-NI-porep-params
branch
from
ab4a893 to
04c54c9
Compare
anorth
reviewed
May 3, 2024
ZenGround0
force-pushed
the
fip-0090/future-proof-NI-porep-params
branch
from
07eb724 to
6305cf5
Compare
anorth
approved these changes
May 6, 2024
jsoares
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed SealerActor FIP #993 is needed to fully unlock SaaS functionality after landing FIP 0090.
To avoid an annoying method deprecation we're predicting the needs of the SealerActor in the NI porep params. This PR adds fields for specifying sealer actor id and sealer actor specified sector number to the NI porep method. The protocol should enforce that these values are constrained until the sealer actor fip arrives.