Repository navigation
Conversation
Owner
Author
|
Self-review of head 747d792:
Open VSX remains under external review; the official inquiry draft is unsent at the user's request. This PR changes tests and documentation only and must not replace or republish version 5.3.14. |
Owner
Author
|
Superseded by #65, which includes this coverage plus the reproduced persistent-permission scope fix and the single 5.3.15 version bump. The failed PR diagnostic run and original artifacts remain preserved; its failure was not rerun or reclassified as passing. Issues #62 and #64 will close only when #65 merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDE 2.5.5 uses the same one-time permission form for MCP and Read URL requests, but the replay suite only covered terminal, browser-domain and generic layouts. Add sanitized native snapshots for both forms and for an actual error Retry button, then check the production target revalidation against changed values and RuntimeIds. Retry is checked independently of its captured offscreen state.
The original six fixtures remain unchanged. The exact nine-file set and explicit assertion counts reject missing or substituted coverage. Add an IDE upgrade self-check with the limits of each native result, and record three harness lessons.
Validation: full local
npm test, Windows PowerShell 5.1 and PowerShell 7 nine-layout replay, and VSIX validation passed. Removing either target guard or allowing Retry makes the corresponding regression fail in both engines. Independent review found no actionable issues.Native approval evidence uses the immutable 5.3.14 package: terminal, MCP and Read URL each produced one matching approval event. The MCP tool subsequently rejected its path; Read URL subsequently encountered a stopped test server. Those outcomes do not establish successful file writes or URL content retrieval. Browser JavaScript was not verified because the IDE browser service returned a region restriction. WSL terminal approval passed with the extension and scanner on Windows at 175% scaling; WSL browser and Chinese UI checks remain unverified when the time limit was reached.
This changes tests and documentation only, so it does not increment the version or replace the published 5.3.14 package. Open VSX 5.3.14 is still under external review; the official inquiry draft remains unsent at the user's request.
Closes #62