Skip to content

test: cover IDE 2.5.5 permission forms and upgrade checks - #63

Closed
fhgffy wants to merge 1 commit into
mainfrom
codex/ide255-approval-coverage
Closed

fhgffy wants to merge 1 commit into
mainfrom
codex/ide255-approval-coverage

Conversation

@fhgffy

@fhgffy fhgffy commented Oct 26, 2026

Copy link
Copy Markdown
Owner

IDE 2.5.5 uses the same one-time permission form for MCP and Read URL requests, but the replay suite only covered terminal, browser-domain and generic layouts. Add sanitized native snapshots for both forms and for an actual error Retry button, then check the production target revalidation against changed values and RuntimeIds. Retry is checked independently of its captured offscreen state.

The original six fixtures remain unchanged. The exact nine-file set and explicit assertion counts reject missing or substituted coverage. Add an IDE upgrade self-check with the limits of each native result, and record three harness lessons.

Validation: full local npm test, Windows PowerShell 5.1 and PowerShell 7 nine-layout replay, and VSIX validation passed. Removing either target guard or allowing Retry makes the corresponding regression fail in both engines. Independent review found no actionable issues.

Native approval evidence uses the immutable 5.3.14 package: terminal, MCP and Read URL each produced one matching approval event. The MCP tool subsequently rejected its path; Read URL subsequently encountered a stopped test server. Those outcomes do not establish successful file writes or URL content retrieval. Browser JavaScript was not verified because the IDE browser service returned a region restriction. WSL terminal approval passed with the extension and scanner on Windows at 175% scaling; WSL browser and Chinese UI checks remain unverified when the time limit was reached.

This changes tests and documentation only, so it does not increment the version or replace the published 5.3.14 package. Open VSX 5.3.14 is still under external review; the official inquiry draft remains unsent at the user's request.

Closes #62

@fhgffy

fhgffy commented Oct 26, 2026

Copy link
Copy Markdown
Owner Author

Self-review of head 747d792:

  • Reviewed all seven changed files. Runtime source, package identity, workflow files and the original six fixtures are unchanged. New fixture mappings were checked against retained native UIA captures, with identifying values sanitized.
  • Local full tests, both-engine nine-layout replay, three single-guard mutations per engine, strict UTF-8/no-BOM/CRLF checks and packaged runtime-byte validation passed. Independent review found no actionable issues in the five test/guide files; README and the three lesson entries were separately self-reviewed.
  • Branch push validation run 40358197540 passed both engines and verified packaging. PR run 40358332840 failed the existing Windows PowerShell 5.1 scanner SelfTest wrapper timeout diagnostic case (tests/host-wrapper.test.cjs:364): the bounded dump collector timed out and the dump header was empty instead of MDMP. The PR's scanner regression and PowerShell 7 job passed. This does not establish the failure's root cause and the passing push run does not cancel it.
  • Preserve the failed PR run and its host-child-timeout artifact. No threshold, assertion, original failure or diagnostic guard has been removed; no rerun was requested. Keep the PR open and unmerged pending investigation. The time-bounded native coverage session is closed with the remaining cases explicitly unverified.

Open VSX remains under external review; the official inquiry draft is unsent at the user's request. This PR changes tests and documentation only and must not replace or republish version 5.3.14.

@fhgffy

fhgffy commented Oct 26, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #65, which includes this coverage plus the reproduced persistent-permission scope fix and the single 5.3.15 version bump. The failed PR diagnostic run and original artifacts remain preserved; its failure was not rerun or reclassified as passing. Issues #62 and #64 will close only when #65 merges.

@fhgffy fhgffy closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cover native IDE 2.5.5 MCP approval and document compatibility checks

1 participant