feat: extend DelimitedCollection to set, frozenset, and tuple#81
Conversation
Generalize `DelimitedCollection` beyond `list` to also parse and serialize `set`, `frozenset`, and `tuple` fields — including the variadic `tuple[T, ...]` and fixed-arity, heterogeneous `tuple[T1, T2, ...]` (whose arity and per-position types Pydantic validates). The `mode="before"` validator splits a cell into a flat list of strings and lets Pydantic coerce it into the declared container. `list`/`tuple` preserve element order; `set`/`frozenset` are serialized sorted by serialized form so output is stable across runs and roundtrips. Empty elements map to `None` where the corresponding element type is optional (uniform element type for list/set/frozenset/variadic-tuple, per-position for fixed tuples). Adds the `is_collection` typing helper. Relates to #76. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 59 minutes and 59 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
1 participant
Summary
This PR is the second in a stack to expand
Metric's collection parsing behavior to supporttuple,set, anddictalong with the existinglistsupport, to provide parity with fgpyo.Generalize
DelimitedCollectionbeyondlistto also parse and serializeset,frozenset, andtuple. Both the variadictuple[T, ...]and the heterogeneoustuple[T1, T2, ...]are supported. (Pydantic natively validates the arity and per-position types of the latter.)Related Stack