Skip to content

hotfix: flatten buttons and repair breadcrumb contrast - #26

Merged
feril3 merged 10 commits into
mainfrom
hotfix/button-breadcrumb-contrast
Sep 22, 2026
Merged

feril3 merged 10 commits into
mainfrom
hotfix/button-breadcrumb-contrast

Conversation

@feril3

@feril3 feril3 commented Sep 22, 2026

Copy link
Copy Markdown
Owner

Visual hotfix — buttons + breadcrumb

Targeted fixes from the latest UI screenshots. This is not Phase 6D.

Buttons

  • remove faux depth shadows from primary and outline buttons
  • add appearance-none because Tailwind preflight is intentionally disabled
  • establish a transparent base border so native browser button chrome cannot leak through
  • keep outline hierarchy via border/background only
  • mark Slot-rendered links with data-slot="button"

Link contrast

  • move the global anchor reset into the Tailwind base cascade layer
  • define explicit layer order so semantic utilities such as text-primary-foreground win over the reset
  • fixes dark text leaking into green primary Link buttons such as Kas Keluar
  • also protects other semantic link colors from the same cascade issue

Breadcrumb

  • remove span.contents wrappers from list composition and use React Fragment
  • explicitly reset ol margin, padding, and list markers because preflight is disabled
  • normalize line-height and separator alignment
  • make separators shrink-safe and slightly smaller

Settings

  • global Button primitive changes apply to all Settings CTA/action buttons
  • make Settings desktop navigation read as navigation rather than a vertical stack of buttons
  • replace inset-shadow active state with a flat left indicator

Regression

  • lock no-shadow/native-chrome button rules
  • lock cascade layer ordering
  • lock valid breadcrumb composition/reset
  • lock flat Settings navigation styling

@feril3
feril3 merged commit 4429bd1 into main Sep 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant