fix: extend transaction_get lookup to observe all pending cache obligations#627
Merged
Conversation
Contributor
cceckman-at-fastly
left a comment
cceckman-at-fastly
left a comment
There was a problem hiding this comment.
Per chat -- I'm actually confused as to how the test passes at HEAD / why the fix fixes it; it looks to me like the fix would collapse when we shouldn't? But I suspect I'm missing something
THad04
force-pushed
the
feature/cache-test-collapse-626
branch
from
2e24b2f to
5559cb3
Compare
Contributor
cceckman-at-fastly
left a comment
cceckman-at-fastly
left a comment
There was a problem hiding this comment.
Overall looks good! A couple cleanup suggestions & one point for discussion, but overall this seems like it does the trick!
cceckman-at-fastly
approved these changes
May 29, 2026
cceckman-at-fastly
added
the
skip-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #626
Description
This PR addresses issue #626. The goal was to implement an integration test verifying request-collapsing safety when handling dynamic HTTP
Varyheader evaluations. The test passed, showing that this edge case is covered.Changes
test_collapse_from_later_varytotest-fixtures/src/bin/cache.rs. It handles explicit host-side handle cleanup via.cancel_insert_or_update().Verification