-
Notifications
You must be signed in to change notification settings - Fork 570
Fix CI to resolve current fastlane dependencies (bump bundler to 2.4.22, downgrade Ruby to 2.7.8)
#1237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix CI to resolve current fastlane dependencies (bump bundler to 2.4.22, downgrade Ruby to 2.7.8)
#1237
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.1.1 | ||
| 2.6.6 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -286,4 +286,4 @@ DEPENDENCIES | |
| xcov | ||
|
|
||
| BUNDLED WITH | ||
| 2.3.21 | ||
| 2.4.22 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there any combination of dependencies that keep the Ruby version at or above 3.1.1? This was last bumped 2 years ago and it sounds like a regression to revert back to a unsupported Ruby version 😬😬
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but that's what works fastlane/fastlane — the CircleCI and images use that already. It seems that Netlify can't work with non-default bundler otherwise so downgrading Netlify to the same env as CircleCI, not introducing nothing "new", see my elaboration: #1234 (comment) +here #1237 (comment) for the steps and reasoning. (Not that I particularly like it myself, but w/e 🤷…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it 😅
Hey can you DM me on https://twitter.com/rogerluan_ or email me? (Email is in my GH profile) — I wanna reach out to you about something but couldn't find a contact :)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I can imagine better circumstances too;) but that is probably just tentatively until upstream tooling in fastlane/fastlane runs Ruby 3.3 and all the images consumed here are updated accordingly — but here we can only consume what't published upstream so…;) 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogerluan That's intentional;) Look around your filtered folders for my username, or just gmail me at that…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW the .ruby-version is not really needed for CircleCI or local work, quite the contrary, so if someone feels fancy enough to just print the file during a CI run (specifically, a PR targeted preview CI only, not elsewhere), after checkout, before configuring the runtime env, this could be better fixed somewhere in the tooling to shim it only for Netlify previews. But I'm not a hotshot like that so it's just an idea for someone more comfortable with breaking and fixing things properly;D
This sucks because it basically ask for a zombie version for local work (pretty much a macOS default Ruby version FWIW;D) even thou the docs project builds happily at more current 3.x (and that should be used in local dev anyways…), I just don't have the imagination to fix the two disjoining pipelines without messing up the local workspace TBH:/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for the laughs — if you omit the ruby version completely, Netlify running the same image (note the sha) will pick different ruby versions for fastlane/docs ❌ and janbrasna/docs ✅: #1244 (comment) 🤷
#givinup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So to match what's now running in the test docker, I've tried the highest security update version for Ruby 2.x ever — the 2.7.8 — and that seems to work in both workflows. Hopefully that's the least lame we can do now.